third_party/WebKit/Source/platform/exported/WebPresentationReceiver.cpp - Issue 2340433003: [Presentation API] 1-UA: notify receiver page when receiver connection becomes available (blink sid…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebPresentationReceiver.cpp

Issue 2340433003: [Presentation API] 1-UA: notify receiver page when receiver connection becomes available (blink sid… (Closed)

Patch Set: resolve code review comments from dcheng Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/BUILD.gn ('k') | third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebPresentationReceiver.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebURLLoaderClient.cpp b/third_party/WebKit/Source/platform/exported/WebPresentationReceiver.cpp

similarity index 51%

copy from third_party/WebKit/Source/platform/exported/WebURLLoaderClient.cpp

copy to third_party/WebKit/Source/platform/exported/WebPresentationReceiver.cpp

index 9e987d15977772eab4f6bfaac89ac4c780b143a8..f54a1828eb8de07c0243c4abc33245b9f58633c5 100644

--- a/third_party/WebKit/Source/platform/exported/WebURLLoaderClient.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebPresentationReceiver.cpp

@@ -2,10 +2,10 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "public/platform/WebURLLoaderClient.h"

+#include "public/platform/modules/presentation/WebPresentationReceiver.h"

-// This WebURLLoaderClient.cpp, which includes only

-// WebURLLoaderClient.h, should be in Source/platform/exported,

-// because WebURLLoaderClient is not compiled without this cpp.

+// This WebPresentationReceiver.cpp, which includes only

+// WebPresentationReceiver.h, should be in Source/platform/exported,

+// because WebPresentationReceiver is not compiled without this cpp.

// So if we don't have this cpp, we will see unresolved symbol error

// when constructor/destructor's address is required.