Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp

Issue 2340433003: [Presentation API] 1-UA: notify receiver page when receiver connection becomes available (blink sid… (Closed)
Patch Set: resolve code review comments from dcheng Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp
diff --git a/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp b/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp
index a41ce2bca7eb8790e7e7129342bfa2ee6982ae5f..f4dee9b4960b9651ed939c1feb368285b8cc6506 100644
--- a/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp
+++ b/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp
@@ -10,6 +10,7 @@
#include "core/testing/DummyPageHolder.h"
#include "modules/presentation/PresentationConnectionList.h"
#include "platform/testing/URLTestHelpers.h"
+#include "public/platform/modules/presentation/WebPresentationClient.h"
#include "public/platform/modules/presentation/WebPresentationConnectionClient.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -32,6 +33,48 @@ public:
MOCK_METHOD2(handleEvent, void(ExecutionContext* executionContext, Event*));
};
+class MockWebPresentationClient : public WebPresentationClient {
+public:
+ MOCK_METHOD1(setController,
+ void(WebPresentationController*));
+
+ MOCK_METHOD1(setReceiver,
+ void(WebPresentationReceiver*));
+
+ MOCK_METHOD2(startSession,
+ void(const WebVector<WebURL>& presentationUrls, WebPresentationConnectionClientCallbacks*));
+
+ MOCK_METHOD3(joinSession,
+ void(const WebVector<WebURL>& presentationUrls, const WebString& presentationId, WebPresentationConnectionClientCallbacks*));
+
+ MOCK_METHOD3(sendString,
+ void(const WebURL& presentationUrl, const WebString& presentationId, const WebString& message));
+
+ MOCK_METHOD4(sendArrayBuffer,
+ void(const WebURL& presentationUrl, const WebString& presentationId, const uint8_t* data, size_t length));
+
+ MOCK_METHOD4(sendBlobData,
+ void(const WebURL& presentationUrl, const WebString& presentationId, const uint8_t* data, size_t length));
+
+ MOCK_METHOD2(closeSession,
+ void(const WebURL& presentationUrl, const WebString& presentationId));
+
+ MOCK_METHOD2(terminateSession,
+ void(const WebURL& presentationUrl, const WebString& presentationId));
+
+ MOCK_METHOD2(getAvailability,
+ void(const WebURL& availabilityUrl, WebPresentationAvailabilityCallbacks*));
+
+ MOCK_METHOD1(startListening,
+ void(WebPresentationAvailabilityObserver*));
+
+ MOCK_METHOD1(stopListening,
+ void(WebPresentationAvailabilityObserver*));
+
+ MOCK_METHOD1(setDefaultPresentationUrls,
+ void(const WebVector<WebURL>&));
+};
+
class TestWebPresentationConnectionClient : public WebPresentationConnectionClient {
public:
WebString getId() override { return WebString::fromUTF8("id"); }
@@ -74,7 +117,7 @@ using ::testing::StrictMock;
TEST_F(PresentationReceiverTest, NoConnectionUnresolvedConnectionList)
{
V8TestingScope scope;
- auto receiver = new PresentationReceiver(&scope.frame());
+ auto receiver = new PresentationReceiver(&scope.frame(), nullptr);
auto eventHandler = new StrictMock<MockEventListener>();
addConnectionavailableEventListener(eventHandler, receiver);
@@ -89,7 +132,7 @@ TEST_F(PresentationReceiverTest, NoConnectionUnresolvedConnectionList)
TEST_F(PresentationReceiverTest, OneConnectionResolvedConnectionListNoEvent)
{
V8TestingScope scope;
- auto receiver = new PresentationReceiver(&scope.frame());
+ auto receiver = new PresentationReceiver(&scope.frame(), nullptr);
auto eventHandler = new StrictMock<MockEventListener>();
addConnectionavailableEventListener(eventHandler, receiver);
@@ -99,7 +142,7 @@ TEST_F(PresentationReceiverTest, OneConnectionResolvedConnectionListNoEvent)
// Receive first connection.
auto connectionClient = new TestWebPresentationConnectionClient();
- receiver->onConnectionReceived(connectionClient);
+ receiver->onReceiverConnectionAvailable(connectionClient);
verifyConnectionListPropertyState(ScriptPromisePropertyBase::Resolved, receiver);
verifyConnectionListSize(1, receiver);
@@ -108,7 +151,7 @@ TEST_F(PresentationReceiverTest, OneConnectionResolvedConnectionListNoEvent)
TEST_F(PresentationReceiverTest, TwoConnectionsFireOnconnectionavailableEvent)
{
V8TestingScope scope;
- auto receiver = new PresentationReceiver(&scope.frame());
+ auto receiver = new PresentationReceiver(&scope.frame(), nullptr);
StrictMock<MockEventListener>* eventHandler = new StrictMock<MockEventListener>();
addConnectionavailableEventListener(eventHandler, receiver);
@@ -117,11 +160,11 @@ TEST_F(PresentationReceiverTest, TwoConnectionsFireOnconnectionavailableEvent)
receiver->connectionList(scope.getScriptState());
// Receive first connection.
auto connectionClient1 = new TestWebPresentationConnectionClient();
- receiver->onConnectionReceived(connectionClient1);
+ receiver->onReceiverConnectionAvailable(connectionClient1);
// Receive second connection.
auto connectionClient2 = new TestWebPresentationConnectionClient();
- receiver->onConnectionReceived(connectionClient2);
+ receiver->onReceiverConnectionAvailable(connectionClient2);
verifyConnectionListSize(2, receiver);
}
@@ -129,7 +172,7 @@ TEST_F(PresentationReceiverTest, TwoConnectionsFireOnconnectionavailableEvent)
TEST_F(PresentationReceiverTest, TwoConnectionsNoEvent)
{
V8TestingScope scope;
- auto receiver = new PresentationReceiver(&scope.frame());
+ auto receiver = new PresentationReceiver(&scope.frame(), nullptr);
StrictMock<MockEventListener>* eventHandler = new StrictMock<MockEventListener>();
addConnectionavailableEventListener(eventHandler, receiver);
@@ -137,15 +180,24 @@ TEST_F(PresentationReceiverTest, TwoConnectionsNoEvent)
// Receive first connection.
auto connectionClient1 = new TestWebPresentationConnectionClient();
- receiver->onConnectionReceived(connectionClient1);
+ receiver->onReceiverConnectionAvailable(connectionClient1);
// Receive second connection.
auto connectionClient2 = new TestWebPresentationConnectionClient();
- receiver->onConnectionReceived(connectionClient2);
+ receiver->onReceiverConnectionAvailable(connectionClient2);
receiver->connectionList(scope.getScriptState());
verifyConnectionListPropertyState(ScriptPromisePropertyBase::Resolved, receiver);
verifyConnectionListSize(2, receiver);
}
+TEST_F(PresentationReceiverTest, CreateReceiver)
+{
+ MockWebPresentationClient client;
+ EXPECT_CALL(client, setReceiver(testing::_));
+
+ V8TestingScope scope;
+ new PresentationReceiver(&scope.frame(), &client);
+}
+
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698