|
|
Created:
4 years, 3 months ago by kjellander_chromium Modified:
4 years, 3 months ago CC:
chromium-reviews, oshima+watch_chromium.org, fukino Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests will be rewrit… (patchset #17 id:320001 of https://codereview.chromium.org/2292473002/ )
Reason for revert:
Breaks "Linux Chromium OS ASan LSan Tests (1)" like this:
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/16114
Snippet:
==24096==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 40 byte(s) in 1 object(s) allocated from:
#0 0x55a84b in operator new(unsigned long) (/b/swarming/w/iroDkF6G/out/Release/chromeos_unittests+0x55a84b)
#1 0x805c51 in (anonymous namespace)::DiskMountManagerTest::SetUp() chromeos/disks/disk_mount_manager_unittest.cc:428:9
#2 0x2c3a936 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
Original issue's description:
> Add a mock class for DiskMountManagerObserver.
> disk_mount_manager_unittest.cc will be rewritten using this class instead of gmock.
>
> BUG=641943
>
> Committed: https://crrev.com/7bec88d891d568be4392e3e5d74d04b79ff4e667
> Cr-Commit-Position: refs/heads/master@{#418182}
TBR=satorux@google.com,satorux@chromium.org,yamaguchi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641943
Committed: https://crrev.com/dae37c463b67bc923d301e347177c7d5c874cce7
Cr-Commit-Position: refs/heads/master@{#418219}
Patch Set 1 #
Messages
Total messages: 10 (7 generated)
The CQ bit was checked by kjellander@chromium.org
Created Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests will be rewrit…
Message was sent while issue was closed.
Description was changed from ========== Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests will be rewrit… (patchset #17 id:320001 of https://codereview.chromium.org/2292473002/ ) Reason for revert: Breaks "Linux Chromium OS ASan LSan Tests (1)" like this: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2... Snippet: ==24096==ERROR: LeakSanitizer: detected memory leaks Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x55a84b in operator new(unsigned long) (/b/swarming/w/iroDkF6G/out/Release/chromeos_unittests+0x55a84b) #1 0x805c51 in (anonymous namespace)::DiskMountManagerTest::SetUp() chromeos/disks/disk_mount_manager_unittest.cc:428:9 #2 0x2c3a936 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12 #3 0x2c3a936 in testing::Test::Run() testing/gtest/src/gtest.cc:2470 #4 0x2c3cafb in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11 #5 0x2c3d8b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28 #6 0x2c518b6 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43 #7 0x2c50f17 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12 #8 0x2c50f17 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255 #9 0x290b60b in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46 #10 0x290b60b in base::TestSuite::Run() base/test/test_suite.cc:246 #11 0x2910983 in Run base/callback.h:64:12 #12 0x2910983 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:206 #13 0x2910665 in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:445:10 #14 0x2909844 in main base/test/run_all_unittests.cc:12:10 #15 0x7f3c903677ec in __libc_start_main /build/eglibc-oqps9y/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Add a mock class for DiskMountManagerObserver. > disk_mount_manager_unittest.cc will be rewritten using this class instead of gmock. > > BUG=641943 > > Committed: https://crrev.com/7bec88d891d568be4392e3e5d74d04b79ff4e667 > Cr-Commit-Position: refs/heads/master@{#418182} TBR=satorux@google.com,satorux@chromium.org,yamaguchi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641943 ========== to ========== Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests will be rewrit… (patchset #17 id:320001 of https://codereview.chromium.org/2292473002/ ) Reason for revert: Breaks "Linux Chromium OS ASan LSan Tests (1)" like this: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2... Snippet: ==24096==ERROR: LeakSanitizer: detected memory leaks Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x55a84b in operator new(unsigned long) (/b/swarming/w/iroDkF6G/out/Release/chromeos_unittests+0x55a84b) #1 0x805c51 in (anonymous namespace)::DiskMountManagerTest::SetUp() chromeos/disks/disk_mount_manager_unittest.cc:428:9 #2 0x2c3a936 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12 #3 0x2c3a936 in testing::Test::Run() testing/gtest/src/gtest.cc:2470 #4 0x2c3cafb in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11 #5 0x2c3d8b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28 #6 0x2c518b6 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43 #7 0x2c50f17 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12 #8 0x2c50f17 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255 #9 0x290b60b in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46 #10 0x290b60b in base::TestSuite::Run() base/test/test_suite.cc:246 #11 0x2910983 in Run base/callback.h:64:12 #12 0x2910983 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:206 #13 0x2910665 in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:445:10 #14 0x2909844 in main base/test/run_all_unittests.cc:12:10 #15 0x7f3c903677ec in __libc_start_main /build/eglibc-oqps9y/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Add a mock class for DiskMountManagerObserver. > disk_mount_manager_unittest.cc will be rewritten using this class instead of gmock. > > BUG=641943 > > Committed: https://crrev.com/7bec88d891d568be4392e3e5d74d04b79ff4e667 > Cr-Commit-Position: refs/heads/master@{#418182} TBR=satorux@google.com,satorux@chromium.org,yamaguchi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641943 ==========
Message was sent while issue was closed.
Description was changed from ========== Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests will be rewrit… (patchset #17 id:320001 of https://codereview.chromium.org/2292473002/ ) Reason for revert: Breaks "Linux Chromium OS ASan LSan Tests (1)" like this: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2... Snippet: ==24096==ERROR: LeakSanitizer: detected memory leaks Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x55a84b in operator new(unsigned long) (/b/swarming/w/iroDkF6G/out/Release/chromeos_unittests+0x55a84b) #1 0x805c51 in (anonymous namespace)::DiskMountManagerTest::SetUp() chromeos/disks/disk_mount_manager_unittest.cc:428:9 #2 0x2c3a936 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12 #3 0x2c3a936 in testing::Test::Run() testing/gtest/src/gtest.cc:2470 #4 0x2c3cafb in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11 #5 0x2c3d8b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28 #6 0x2c518b6 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43 #7 0x2c50f17 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12 #8 0x2c50f17 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255 #9 0x290b60b in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46 #10 0x290b60b in base::TestSuite::Run() base/test/test_suite.cc:246 #11 0x2910983 in Run base/callback.h:64:12 #12 0x2910983 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:206 #13 0x2910665 in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:445:10 #14 0x2909844 in main base/test/run_all_unittests.cc:12:10 #15 0x7f3c903677ec in __libc_start_main /build/eglibc-oqps9y/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Add a mock class for DiskMountManagerObserver. > disk_mount_manager_unittest.cc will be rewritten using this class instead of gmock. > > BUG=641943 > > Committed: https://crrev.com/7bec88d891d568be4392e3e5d74d04b79ff4e667 > Cr-Commit-Position: refs/heads/master@{#418182} TBR=satorux@google.com,satorux@chromium.org,yamaguchi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641943 ========== to ========== Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests will be rewrit… (patchset #17 id:320001 of https://codereview.chromium.org/2292473002/ ) Reason for revert: Breaks "Linux Chromium OS ASan LSan Tests (1)" like this: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2... Snippet: ==24096==ERROR: LeakSanitizer: detected memory leaks Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x55a84b in operator new(unsigned long) (/b/swarming/w/iroDkF6G/out/Release/chromeos_unittests+0x55a84b) #1 0x805c51 in (anonymous namespace)::DiskMountManagerTest::SetUp() chromeos/disks/disk_mount_manager_unittest.cc:428:9 #2 0x2c3a936 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12 #3 0x2c3a936 in testing::Test::Run() testing/gtest/src/gtest.cc:2470 #4 0x2c3cafb in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11 #5 0x2c3d8b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28 #6 0x2c518b6 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43 #7 0x2c50f17 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12 #8 0x2c50f17 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255 #9 0x290b60b in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46 #10 0x290b60b in base::TestSuite::Run() base/test/test_suite.cc:246 #11 0x2910983 in Run base/callback.h:64:12 #12 0x2910983 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:206 #13 0x2910665 in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:445:10 #14 0x2909844 in main base/test/run_all_unittests.cc:12:10 #15 0x7f3c903677ec in __libc_start_main /build/eglibc-oqps9y/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Add a mock class for DiskMountManagerObserver. > disk_mount_manager_unittest.cc will be rewritten using this class instead of gmock. > > BUG=641943 > > Committed: https://crrev.com/7bec88d891d568be4392e3e5d74d04b79ff4e667 > Cr-Commit-Position: refs/heads/master@{#418182} TBR=satorux@google.com,satorux@chromium.org,yamaguchi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641943 Committed: https://crrev.com/dae37c463b67bc923d301e347177c7d5c874cce7 Cr-Commit-Position: refs/heads/master@{#418219} ==========
Message was sent while issue was closed.
Description was changed from ========== Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests will be rewrit… (patchset #17 id:320001 of https://codereview.chromium.org/2292473002/ ) Reason for revert: Breaks "Linux Chromium OS ASan LSan Tests (1)" like this: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2... Snippet: ==24096==ERROR: LeakSanitizer: detected memory leaks Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x55a84b in operator new(unsigned long) (/b/swarming/w/iroDkF6G/out/Release/chromeos_unittests+0x55a84b) #1 0x805c51 in (anonymous namespace)::DiskMountManagerTest::SetUp() chromeos/disks/disk_mount_manager_unittest.cc:428:9 #2 0x2c3a936 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12 #3 0x2c3a936 in testing::Test::Run() testing/gtest/src/gtest.cc:2470 #4 0x2c3cafb in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11 #5 0x2c3d8b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28 #6 0x2c518b6 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43 #7 0x2c50f17 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12 #8 0x2c50f17 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255 #9 0x290b60b in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46 #10 0x290b60b in base::TestSuite::Run() base/test/test_suite.cc:246 #11 0x2910983 in Run base/callback.h:64:12 #12 0x2910983 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:206 #13 0x2910665 in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:445:10 #14 0x2909844 in main base/test/run_all_unittests.cc:12:10 #15 0x7f3c903677ec in __libc_start_main /build/eglibc-oqps9y/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Add a mock class for DiskMountManagerObserver. > disk_mount_manager_unittest.cc will be rewritten using this class instead of gmock. > > BUG=641943 > > Committed: https://crrev.com/7bec88d891d568be4392e3e5d74d04b79ff4e667 > Cr-Commit-Position: refs/heads/master@{#418182} TBR=satorux@google.com,satorux@chromium.org,yamaguchi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641943 Committed: https://crrev.com/dae37c463b67bc923d301e347177c7d5c874cce7 Cr-Commit-Position: refs/heads/master@{#418219} ========== to ========== Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests will be rewrit… (patchset #17 id:320001 of https://codereview.chromium.org/2292473002/ ) Reason for revert: Breaks "Linux Chromium OS ASan LSan Tests (1)" like this: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2... Snippet: ==24096==ERROR: LeakSanitizer: detected memory leaks Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x55a84b in operator new(unsigned long) (/b/swarming/w/iroDkF6G/out/Release/chromeos_unittests+0x55a84b) #1 0x805c51 in (anonymous namespace)::DiskMountManagerTest::SetUp() chromeos/disks/disk_mount_manager_unittest.cc:428:9 #2 0x2c3a936 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12 Original issue's description: > Add a mock class for DiskMountManagerObserver. > disk_mount_manager_unittest.cc will be rewritten using this class instead of gmock. > > BUG=641943 > > Committed: https://crrev.com/7bec88d891d568be4392e3e5d74d04b79ff4e667 > Cr-Commit-Position: refs/heads/master@{#418182} TBR=satorux@google.com,satorux@chromium.org,yamaguchi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641943 Committed: https://crrev.com/dae37c463b67bc923d301e347177c7d5c874cce7 Cr-Commit-Position: refs/heads/master@{#418219} ==========
The CQ bit was checked by kjellander@chromium.org
The CQ bit was unchecked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by kjellander@chromium.org
Message was sent while issue was closed.
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing to commit, working tree clean |