Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2340433002: Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests (Closed)

Created:
4 years, 3 months ago by kjellander_chromium
Modified:
4 years, 3 months ago
Reviewers:
yamaguchi, satorux1, satorux
CC:
chromium-reviews, oshima+watch_chromium.org, fukino
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests will be rewrit… (patchset #17 id:320001 of https://codereview.chromium.org/2292473002/ ) Reason for revert: Breaks "Linux Chromium OS ASan LSan Tests (1)" like this: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/16114 Snippet: ==24096==ERROR: LeakSanitizer: detected memory leaks Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x55a84b in operator new(unsigned long) (/b/swarming/w/iroDkF6G/out/Release/chromeos_unittests+0x55a84b) #1 0x805c51 in (anonymous namespace)::DiskMountManagerTest::SetUp() chromeos/disks/disk_mount_manager_unittest.cc:428:9 #2 0x2c3a936 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12 Original issue's description: > Add a mock class for DiskMountManagerObserver. > disk_mount_manager_unittest.cc will be rewritten using this class instead of gmock. > > BUG=641943 > > Committed: https://crrev.com/7bec88d891d568be4392e3e5d74d04b79ff4e667 > Cr-Commit-Position: refs/heads/master@{#418182} TBR=satorux@google.com,satorux@chromium.org,yamaguchi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641943 Committed: https://crrev.com/dae37c463b67bc923d301e347177c7d5c874cce7 Cr-Commit-Position: refs/heads/master@{#418219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -403 lines) Patch
M chromeos/disks/disk_mount_manager_unittest.cc View 18 chunks +222 lines, -403 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
kjellander_chromium
Created Revert of Add a mock class for DiskMountManagerObserver. disk_mount_manager_observer_unittests will be rewrit…
4 years, 3 months ago (2016-09-13 11:10:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340433002/1
4 years, 3 months ago (2016-09-13 11:24:32 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 11:25:01 UTC) #10
Message was sent while issue was closed.
Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

Powered by Google App Engine
This is Rietveld 408576698