Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chromecast/media/cma/pipeline/media_pipeline_impl.h

Issue 2340423002: [chromecast] Deletes dead code to track MediaPipelineBackend. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/cma/pipeline/media_pipeline_impl.h
diff --git a/chromecast/media/cma/pipeline/media_pipeline_impl.h b/chromecast/media/cma/pipeline/media_pipeline_impl.h
index 87fec0e1bce25ea370ceb3d40a30a96089434ae6..1e5959c117f2b4387c2b543cdf676395fb932407 100644
--- a/chromecast/media/cma/pipeline/media_pipeline_impl.h
+++ b/chromecast/media/cma/pipeline/media_pipeline_impl.h
@@ -99,10 +99,12 @@ class MediaPipelineImpl {
// Cached here because CMA pipeline backend does not support rate == 0,
// which is emulated by pausing the backend.
float playback_rate_;
+
+ // Since av pipeline still need to access device components in their
+ // destructor, it's important to delete them first.
std::unique_ptr<MediaPipelineBackend> media_pipeline_backend_;
std::unique_ptr<AudioDecoderSoftwareWrapper> audio_decoder_;
MediaPipelineBackend::VideoDecoder* video_decoder_;
-
std::unique_ptr<AudioPipelineImpl> audio_pipeline_;
std::unique_ptr<VideoPipelineImpl> video_pipeline_;
std::unique_ptr<FlushTask> pending_flush_task_;
« no previous file with comments | « chromecast/media/cma/pipeline/media_pipeline_client.h ('k') | chromecast/media/cma/pipeline/media_pipeline_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698