Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2340373003:
Add device::mojom::TimeZoneMonitor to //content/browser's manifest (Closed)
|
Created:
4 years, 3 months ago by blundell Modified:
4 years, 3 months ago CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd device::mojom::TimeZoneMonitor to //content/browser's manifest
This change should have been part of
https://codereview.chromium.org/2304073003. The CL that restricted
connections to what's specified in the manifest came in in the final
rebase of that initial time zone monitor CL, and I didn't retest after
that final rebase before landing :P.
BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
and then click "recheck" to ensure that the renderer picks up the new
time zone. Don't reload the page, which is likely to give you a new
renderer process, use the "recheck" link on the page.
Patch Set 1 #
Messages
Total messages: 22 (12 generated)
Description was changed from ========== Add device::mojom::TimeZoneMonitor to //content/browser's manifest This change should have been part of https://codereview.chromium.org/2304073003. The CL that restricted connections to what's specified in the manifest came in in the final rebase of my initial time zone monitor CL, and I didn't retest after that final rebase before landing :P. BUG=612341 ========== to ========== Add device::mojom::TimeZoneMonitor to //content/browser's manifest This change should have been part of https://codereview.chromium.org/2304073003. The CL that restricted connections to what's specified in the manifest came in in the final rebase of that initial time zone monitor CL, and I didn't retest after that final rebase before landing :P. BUG=612341 TEST=http://crbug.com/288697#c12: load the page, change the system time zone, and then click "recheck" to ensure that the renderer picks up the new time zone. Don't reload the page, which is likely to give you a new renderer process, use the "recheck" link on the page. ==========
The CQ bit was checked by blundell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
blundell@chromium.org changed reviewers: + jam@chromium.org
If this looks good, can you send it to the CQ? Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
blundell@chromium.org changed reviewers: + dcheng@chromium.org
whoops, this file has security owners. dcheng@, can you review and send to CQ if it looks good?
LGTM (Is there some documentation for the format of this file in case of more substantial changes?)
The CQ bit was checked by blundell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/16 19:15:31, dcheng wrote: > LGTM > > (Is there some documentation for the format of this file in case of more > substantial changes?) AFAIK, What there is is here: https://chromium.googlesource.com/chromium/src/+/master/services/shell/README.md
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2016/09/16 19:38:11, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) This change got incorporated into the reland of https://codereview.chromium.org/2259903002/.
Description was changed from ========== Add device::mojom::TimeZoneMonitor to //content/browser's manifest This change should have been part of https://codereview.chromium.org/2304073003. The CL that restricted connections to what's specified in the manifest came in in the final rebase of that initial time zone monitor CL, and I didn't retest after that final rebase before landing :P. BUG=612341 TEST=http://crbug.com/288697#c12: load the page, change the system time zone, and then click "recheck" to ensure that the renderer picks up the new time zone. Don't reload the page, which is likely to give you a new renderer process, use the "recheck" link on the page. ========== to ========== Add device::mojom::TimeZoneMonitor to //content/browser's manifest This change should have been part of https://codereview.chromium.org/2304073003. The CL that restricted connections to what's specified in the manifest came in in the final rebase of that initial time zone monitor CL, and I didn't retest after that final rebase before landing :P. BUG=612341 TEST=http://crbug.com/288697#c12: load the page, change the system time zone, and then click "recheck" to ensure that the renderer picks up the new time zone. Don't reload the page, which is likely to give you a new renderer process, use the "recheck" link on the page. ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
