Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2340343002: [ARC] Converts part of ios/web/ui to ARC. (Closed)

Created:
4 years, 3 months ago by stkhapugin
Modified:
4 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Converts part of ios/web/ui to ARC. Notable changes: * ios/web/webui/crw_web_ui_page_builder.mm has a block that had a __block reference to itself. Before ARC __block means "do not retain when being captured in a block", but with ARC it is captured. So I added an additional variable of __weak __block type instead. * One WeakNSObject in mojo_facade.h could not be removed because it is included from non-ARC code. WeakNSObject is functional in ARC but is not preferred. Filed crbug.com/639326 to track future removal of this. BUG=639327 TEST=None Committed: https://crrev.com/ae7aa8958c5981d3ced5b179f490b5ea9e00ba64 Cr-Commit-Position: refs/heads/master@{#419458}

Patch Set 1 #

Patch Set 2 : Fixes unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -26 lines) Patch
M ios/web/BUILD.gn View 2 chunks +15 lines, -15 lines 0 comments Download
M ios/web/webui/crw_web_ui_manager.mm View 3 chunks +5 lines, -2 lines 0 comments Download
M ios/web/webui/crw_web_ui_manager_unittest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/crw_web_ui_page_builder.mm View 6 chunks +14 lines, -8 lines 0 comments Download
M ios/web/webui/mojo_facade.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/webui/shared_resources_data_source_ios.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/webui/url_data_manager_ios_backend.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/webui/url_data_source_ios.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
stkhapugin
PTAL. I hope this is sufficiently small. Please tell me if I should make smaller ...
4 years, 3 months ago (2016-09-15 16:51:24 UTC) #2
Eugene But (OOO till 7-30)
Thanks the size if perfect. Adding Jackie to review this as well. lgtm
4 years, 3 months ago (2016-09-15 18:04:19 UTC) #4
Jackie Quinn
On 2016/09/15 18:04:19, Eugene But wrote: > Thanks the size if perfect. Adding Jackie to ...
4 years, 3 months ago (2016-09-16 20:12:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340343002/1
4 years, 3 months ago (2016-09-19 08:32:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/71331)
4 years, 3 months ago (2016-09-19 08:59:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340343002/20001
4 years, 3 months ago (2016-09-19 14:43:38 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 14:59:19 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 15:01:17 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae7aa8958c5981d3ced5b179f490b5ea9e00ba64
Cr-Commit-Position: refs/heads/master@{#419458}

Powered by Google App Engine
This is Rietveld 408576698