Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/enabled-worker.js

Issue 2340323002: Add Origin Trials Test interface, rather than attaching trials directly to internals. (Closed)
Patch Set: IDL-backed methods are not static on full interfaces Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/enabled-worker.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/enabled-worker.js b/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/enabled-worker.js
index fcf47339d80676284a95a80f08776b0dfcd74a8e..41a78f15e49cbd181b18a1acdb8d19d4d70e6e92 100644
--- a/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/enabled-worker.js
+++ b/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/enabled-worker.js
@@ -2,16 +2,19 @@ importScripts('/resources/testharness.js');
// The trial should be enabled.
test(() => {
- assert_idl_attribute(self.internals, 'frobulate');
- assert_true(self.internals.frobulate, 'Attribute should return boolean value');
+ var testObject = self.internals.originTrialsTest();
+ assert_idl_attribute(testObject, 'throwingAttribute');
+ assert_true(testObject.throwingAttribute, 'Attribute should return boolean value');
}, 'Attribute should exist and return value in worker');
chasej 2016/09/16 15:17:02 It pre-dates this CL, but there intentionally isn'
iclelland 2016/09/16 15:59:46 Yes it does; I should probably add the normalAttri
test(() => {
- assert_idl_attribute(self.internals, 'FROBULATE_CONST');
- assert_equals(self.internals.FROBULATE_CONST, 1, 'Constant should return integer value');
+ var testObject = self.internals.originTrialsTest();
+ assert_idl_attribute(testObject, 'CONSTANT');
+ assert_equals(testObject.CONSTANT, 1, 'Constant should return integer value');
}, 'Constant should exist and return value in worker');
test(() => {
- assert_idl_attribute(self.internals, 'FROBULATE_CONST');
- self.internals.FROBULATE_CONST = 10;
- assert_equals(self.internals.FROBULATE_CONST, 1, 'Constant should not be modifiable');
+ var testObject = self.internals.originTrialsTest();
+ assert_idl_attribute(testObject, 'CONSTANT');
+ testObject.CONSTANT = 10;
+ assert_equals(testObject.CONSTANT, 1, 'Constant should not be modifiable');
}, 'Constant should exist and not be modifiable in worker');
done();

Powered by Google App Engine
This is Rietveld 408576698