Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 2340293002: [compiler] Make Compiler::EnsureBytecode respect filter. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Make Compiler::EnsureBytecode respect filter. This ensures that {Compiler::EnsureBytecode} fails gracefully in case the --ignition-filter flag prevents generation of bytecode for a certain set of functions. This can be triggered via inlining. R=rmcilroy@chromium.org Committed: https://crrev.com/6a72f3731bdb3a0f175b5dce7dcfad9faab4f4f7 Cr-Commit-Position: refs/heads/master@{#39466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-15 09:12:05 UTC) #3
rmcilroy
LGTM, thanks.
4 years, 3 months ago (2016-09-15 16:22:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340293002/1
4 years, 3 months ago (2016-09-16 08:55:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 08:57:28 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 08:58:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a72f3731bdb3a0f175b5dce7dcfad9faab4f4f7
Cr-Commit-Position: refs/heads/master@{#39466}

Powered by Google App Engine
This is Rietveld 408576698