third_party/WebKit/Source/core/dom/DocumentFullscreen.h - Issue 2340263003: Move Document.fullscreenElement to DocumentOrShadowRoot

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/dom/DocumentFullscreen.h

Issue 2340263003: Move Document.fullscreenElement to DocumentOrShadowRoot (Closed)

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt ('k') | third_party/WebKit/Source/core/dom/DocumentFullscreen.cpp » ('j') | third_party/WebKit/Source/core/dom/Fullscreen.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013, Google Inc. All rights reserved.	2 * Copyright (C) 2013, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are met:	5 * modification, are permitted provided that the following conditions are met:

6 *	6 *

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 21 matching lines...) Expand all Loading...
32 namespace blink {	32 namespace blink {

33	33

34 class Document;	34 class Document;

35 class Element;	35 class Element;

36	36

37 class DocumentFullscreen {	37 class DocumentFullscreen {

38 STATIC_ONLY(DocumentFullscreen);	38 STATIC_ONLY(DocumentFullscreen);

39	39

40 public:	40 public:

41 static bool fullscreenEnabled(Document&);	41 static bool fullscreenEnabled(Document&);

42 static Element* fullscreenElement(Document&);	42 static Element* webkitFullscreenElement(Document&);
	foolip 2016/10/24 15:30:12 Can you keep ImplementedAs in the IDL file? These Can you keep ImplementedAs in the IDL file? These three static methods are called exclusively from bindings, all internal code paths use Fullscreen::something(). kochi 2016/10/25 10:08:04 Done. Show quoted text On 2016/10/24 15:30:12, foolip wrote: > Can you keep ImplementedAs in the IDL file? These three static methods are > called exclusively from bindings, all internal code paths use > Fullscreen::something(). Done.
43 static void exitFullscreen(Document&);	43 static void exitFullscreen(Document&);

44	44

45 DEFINE_STATIC_ATTRIBUTE_EVENT_LISTENER(fullscreenchange);	45 DEFINE_STATIC_ATTRIBUTE_EVENT_LISTENER(fullscreenchange);

46 DEFINE_STATIC_ATTRIBUTE_EVENT_LISTENER(fullscreenerror);	46 DEFINE_STATIC_ATTRIBUTE_EVENT_LISTENER(fullscreenerror);

47	47

48 // Mozilla version	48 // Mozilla version

49 static Element* currentFullScreenElement(Document&);	49 static Element* currentFullScreenElement(Document&);

50	50

51 DEFINE_STATIC_ATTRIBUTE_EVENT_LISTENER(webkitfullscreenchange);	51 DEFINE_STATIC_ATTRIBUTE_EVENT_LISTENER(webkitfullscreenchange);

52 DEFINE_STATIC_ATTRIBUTE_EVENT_LISTENER(webkitfullscreenerror);	52 DEFINE_STATIC_ATTRIBUTE_EVENT_LISTENER(webkitfullscreenerror);

53 };	53 };

54	54

55 } // namespace blink	55 } // namespace blink

56	56

57 #endif // DocumentFullscreen_h	57 #endif // DocumentFullscreen_h

OLD	NEW