Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3237)

Issue 2340253002: Revert of Temporary: Detect WebSocket destruction order problem (Closed)

Created:
4 years, 3 months ago by Adam Rice
Modified:
4 years, 3 months ago
Reviewers:
yhirano, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Temporary: Detect WebSocket destruction order problem (patchset #2 id:20001 of https://codereview.chromium.org/2315213002/ ) Reason for revert: We have learnt everything we are going to learn from this CHECK. Reverting as intended. This does not need to be relanded. Original issue's description: > Temporary: Detect WebSocket destruction order problem > > Add a CHECK() to crash the browser if a destruction order problem is > encountered. > > This will be reverted once the information is collected. > > BUG=641013 > > Committed: https://crrev.com/23169a0f5421e6759d89b1feaa83b06b197a7039 > Cr-Commit-Position: refs/heads/master@{#417522} TBR=yhirano@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=641013 Committed: https://crrev.com/e81003795225965739e3ac1289825832725bf910 Cr-Commit-Position: refs/heads/master@{#418791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M net/http/http_network_session.h View 2 chunks +0 lines, -7 lines 0 comments Download
M net/http/http_network_session.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/websockets/websocket_channel.cc View 3 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Adam Rice
Created Revert of Temporary: Detect WebSocket destruction order problem
4 years, 3 months ago (2016-09-15 04:44:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340253002/1
4 years, 3 months ago (2016-09-15 04:45:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 05:40:18 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 05:41:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e81003795225965739e3ac1289825832725bf910
Cr-Commit-Position: refs/heads/master@{#418791}

Powered by Google App Engine
This is Rietveld 408576698