Allow demo app to access chromeosInfoPrivate API.

Allow demo app to access chromeosInfoPrivate API.

BUG=644458, 646081
TEST=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9867e0f73601951ef9ae3a1c445f744714f23f33
Cr-Commit-Position: refs/heads/master@{#419684}

[oka, 2016-09-15 03:58:26]

Description was changed from

==========
Allow demo app to access chromeosInfoPrivate API.

BUG=644458,646081
TEST=TBD
==========

to

==========
Allow demo app to access chromeosInfoPrivate API.

BUG=644458,646081
TEST=TBD
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-09-15 03:59:23]

Description was changed from

==========
Allow demo app to access chromeosInfoPrivate API.

BUG=644458,646081
TEST=TBD
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Allow demo app to access chromeosInfoPrivate API.

BUG=644458,646081
TEST=TBD
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-09-15 03:59:40]

oka@chromium.org changed reviewers:
+ hirono@chromium.org

[oka, 2016-09-15 03:59:41]

PTAL.

[oka, 2016-09-15 03:59:56]

Description was changed from

==========
Allow demo app to access chromeosInfoPrivate API.

BUG=644458,646081
TEST=TBD
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Allow demo app to access chromeosInfoPrivate API.

BUG=644458,646081
TEST=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hirono, 2016-09-15 04:03:22]

lgtm

[oka, 2016-09-19 09:39:02]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2016-09-19 09:39:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 09:46:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 09:46:39]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[oka, 2016-09-20 03:56:04]

oka@chromium.org changed reviewers:
+ satorux@google.com

[oka, 2016-09-20 03:56:05]

Satoru-san, could you grant OWNER approval?

[satorux1, 2016-09-20 04:35:08]

satorux@chromium.org changed reviewers:
+ satorux@chromium.org

[satorux1, 2016-09-20 04:35:09]

lgtm with a comment

https://codereview.chromium.org/2340243002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/demo_app/manifest.json (right):

https://codereview.chromium.org/2340243002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/demo_app/manifest.json:8: "permissions":
["power", "idle", "videoCapture", "fullscreen", "chromeosInfoPrivate"],
nit: should this be split into two lines? Please check other files and be
consistent with these.

[oka, 2016-09-20 05:05:39]

On 2016/09/20 04:35:09, satorux1 wrote:
> lgtm with a comment
> 
>
https://codereview.chromium.org/2340243002/diff/1/chrome/browser/resources/ch...
> File chrome/browser/resources/chromeos/demo_app/manifest.json (right):
> 
>
https://codereview.chromium.org/2340243002/diff/1/chrome/browser/resources/ch...
> chrome/browser/resources/chromeos/demo_app/manifest.json:8: "permissions":
> ["power", "idle", "videoCapture", "fullscreen", "chromeosInfoPrivate"],
> nit: should this be split into two lines? Please check other files and be
> consistent with these.

Done. Also sorted alphabetically.

[oka, 2016-09-20 05:05:58]

The CQ bit was checked by oka@chromium.org

[oka, 2016-09-20 05:05:59]

The patchset sent to the CQ was uploaded after l-g-t-m from hirono@chromium.org,
satorux@chromium.org
Link to the patchset: https://codereview.chromium.org/2340243002/#ps20001
(title: "Format and sort.")

[commit-bot: I haz the power, 2016-09-20 05:06:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 05:18:37]

Description was changed from

==========
Allow demo app to access chromeosInfoPrivate API.

BUG=644458,646081
TEST=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Allow demo app to access chromeosInfoPrivate API.

BUG=644458,646081
TEST=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-20 05:18:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-20 05:20:39]

Description was changed from

==========
Allow demo app to access chromeosInfoPrivate API.

BUG=644458,646081
TEST=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Allow demo app to access chromeosInfoPrivate API.

BUG=644458,646081
TEST=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9867e0f73601951ef9ae3a1c445f744714f23f33
Cr-Commit-Position: refs/heads/master@{#419684}
==========

[commit-bot: I haz the power, 2016-09-20 05:20:41]

Patchset 2 (id:??) landed as
https://crrev.com/9867e0f73601951ef9ae3a1c445f744714f23f33
Cr-Commit-Position: refs/heads/master@{#419684}