third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js - Issue 2340223002: DevTools: fix ViewportControl's text selection logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js

Issue 2340223002: DevTools: fix ViewportControl's text selection logic (Closed)

Patch Set: add test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js b/third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js

index b8edc115a9ee4291e06b2e6009042ec172aa4131..63e676a1ee12f608ea400e8a6f81f3a803f08213 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js

@@ -567,7 +567,7 @@ WebInspector.ViewportControl.prototype = {

{

var chars = 0;

var node = itemElement;

- while ((node = node.traverseNextTextNode()) && node !== container)

+ while ((node = node.traverseNextTextNode()) && !node.isSelfOrDescendant(container))

chars += node.textContent.length;

return chars + offset;

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection-expected.txt ('k') | no next file » | no next file with comments »