Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2340213003: Add PageBoundaryRule parameter to columnSetAtBlockOffset(). (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PageBoundaryRule parameter to columnSetAtBlockOffset(). If it's an exclusive end offset, we need to know this, so that we map to the former column set, rather than the latter, if the offset is at a column set boundary. Committed: https://crrev.com/7928011b29316b85632b2b16f276382ae857c583 Cr-Commit-Position: refs/heads/master@{#418839}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-15 10:26:26 UTC) #6
eae
LGTM, nice test!
4 years, 3 months ago (2016-09-15 10:31:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340213003/1
4 years, 3 months ago (2016-09-15 11:59:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 12:04:21 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 12:06:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7928011b29316b85632b2b16f276382ae857c583
Cr-Commit-Position: refs/heads/master@{#418839}

Powered by Google App Engine
This is Rietveld 408576698