third_party/WebKit/Source/core/html/HTMLFormElement.h - Issue 2340213002: submit() in submit event handler should not contains a value of a submit button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormElement.h

Issue 2340213002: submit() in submit event handler should not contains a value of a submit button. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFormElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLFormElement.h b/third_party/WebKit/Source/core/html/HTMLFormElement.h

index 0a4c213abf98c3619a8c92b6ce069cf489da57ac..d5db2576aa919d49b087f623a15cf7475201e499 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLFormElement.h

@@ -66,7 +66,7 @@ public:

void disassociate(HTMLImageElement&);

void didAssociateByParser();

- void prepareForSubmission(Event*);

+ void prepareForSubmission(Event*, HTMLFormControlElement* submitButton);

void submitFromJavaScript();

void reset();

@@ -119,7 +119,7 @@ private:

void copyNonAttributePropertiesFromElement(const Element&) override;

void submitDialog(FormSubmission*);

- void submit(Event*, bool activateSubmitButton);

+ void submit(Event*, HTMLFormControlElement* submitButton);

void scheduleFormSubmission(FormSubmission*);