Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

Issue 2340213002: submit() in submit event handler should not contains a value of a submit button. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 if (name == formactionAttr) 107 if (name == formactionAttr)
108 logUpdateAttributeIfIsolatedWorldAndInDocument("button", formactionA ttr, oldValue, value); 108 logUpdateAttributeIfIsolatedWorldAndInDocument("button", formactionA ttr, oldValue, value);
109 HTMLFormControlElement::parseAttribute(name, oldValue, value); 109 HTMLFormControlElement::parseAttribute(name, oldValue, value);
110 } 110 }
111 } 111 }
112 112
113 void HTMLButtonElement::defaultEventHandler(Event* event) 113 void HTMLButtonElement::defaultEventHandler(Event* event)
114 { 114 {
115 if (event->type() == EventTypeNames::DOMActivate && !isDisabledFormControl() ) { 115 if (event->type() == EventTypeNames::DOMActivate && !isDisabledFormControl() ) {
116 if (form() && m_type == SUBMIT) { 116 if (form() && m_type == SUBMIT) {
117 m_isActivatedSubmit = true; 117 form()->prepareForSubmission(event, this);
118 form()->prepareForSubmission(event);
119 event->setDefaultHandled(); 118 event->setDefaultHandled();
120 m_isActivatedSubmit = false; // Do this in case submission was cance led.
121 } 119 }
122 if (form() && m_type == RESET) { 120 if (form() && m_type == RESET) {
123 form()->reset(); 121 form()->reset();
124 event->setDefaultHandled(); 122 event->setDefaultHandled();
125 } 123 }
126 } 124 }
127 125
128 if (event->isKeyboardEvent()) { 126 if (event->isKeyboardEvent()) {
129 if (event->type() == EventTypeNames::keydown && toKeyboardEvent(event)-> key() == " ") { 127 if (event->type() == EventTypeNames::keydown && toKeyboardEvent(event)-> key() == " ") {
130 setActive(true); 128 setActive(true);
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 } 220 }
223 221
224 Node::InsertionNotificationRequest HTMLButtonElement::insertedInto(ContainerNode * insertionPoint) 222 Node::InsertionNotificationRequest HTMLButtonElement::insertedInto(ContainerNode * insertionPoint)
225 { 223 {
226 InsertionNotificationRequest request = HTMLFormControlElement::insertedInto( insertionPoint); 224 InsertionNotificationRequest request = HTMLFormControlElement::insertedInto( insertionPoint);
227 logAddElementIfIsolatedWorldAndInDocument("button", typeAttr, formmethodAttr , formactionAttr); 225 logAddElementIfIsolatedWorldAndInDocument("button", typeAttr, formmethodAttr , formactionAttr);
228 return request; 226 return request;
229 } 227 }
230 228
231 } // namespace blink 229 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698