Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2340193003: NQE: Set RTT thresholds for effective connection type of 3G (Closed)

Created:
4 years, 3 months ago by tbansal1
Modified:
4 years, 2 months ago
Reviewers:
bengr
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NQE: Set RTT thresholds for effective connection type of 3G BUG=647473 Committed: https://crrev.com/45acdf007d1fbbd643c2611f81c28ed186b607b0 Cr-Commit-Position: refs/heads/master@{#422286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M net/nqe/network_quality_estimator.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
tbansal1
4 years, 3 months ago (2016-09-15 22:32:44 UTC) #3
tbansal1
bengr: ptal. thanks.
4 years, 3 months ago (2016-09-15 22:32:55 UTC) #4
bengr
lgtm
4 years, 3 months ago (2016-09-22 22:10:47 UTC) #9
tbansal1
ping. Is this kosher to submit?
4 years, 2 months ago (2016-09-29 17:53:00 UTC) #10
bengr
On 2016/09/29 17:53:00, tbansal1 wrote: > ping. Is this kosher to submit? yes
4 years, 2 months ago (2016-09-30 21:40:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340193003/1
4 years, 2 months ago (2016-09-30 21:41:36 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-01 02:14:40 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-01 02:16:19 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45acdf007d1fbbd643c2611f81c28ed186b607b0
Cr-Commit-Position: refs/heads/master@{#422286}

Powered by Google App Engine
This is Rietveld 408576698