Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2340193002: [inspector] removed ArrayLengthHelperFunction specialization for empty array (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] removed ArrayLengthHelperFunction specialization for empty array There is no zero length array usage in inspector codebase. We can safely remove template specialization. It was reverted to revert another patch and is good by itself. BUG=chromium:635948 TBR=jochen@chromium.org Committed: https://crrev.com/739a04bc02871dd0eeb0630af69f210a75d309eb Cr-Commit-Position: refs/heads/master@{#39454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/inspector/Allocator.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340193002/1
4 years, 3 months ago (2016-09-15 01:22:27 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-15 01:22:28 UTC) #4
kozy
Alexei, I need commuter lgtm to reland it, please take a look.
4 years, 3 months ago (2016-09-15 17:43:05 UTC) #10
alph
On 2016/09/15 17:43:05, kozyatinskiy wrote: > Alexei, I need commuter lgtm to reland it, please ...
4 years, 3 months ago (2016-09-15 18:40:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340193002/1
4 years, 3 months ago (2016-09-15 18:43:53 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 18:47:12 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 18:48:12 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/739a04bc02871dd0eeb0630af69f210a75d309eb
Cr-Commit-Position: refs/heads/master@{#39454}

Powered by Google App Engine
This is Rietveld 408576698