address #25232 in strong mode (dart1 behavior unchanged)

address #25232 in strong mode (dart1 behavior unchanged)

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/0713345b34b996213fd59819b6a8fd460169c062

[Jennifer Messerly, 2016-09-15 01:03:10]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Jennifer Messerly, 2016-09-15 01:03:11]

https://codereview.chromium.org/2340173002/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/2340173002/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/checker_test.dart:3117: class D
/*error:INVALID_METHOD_OVERRIDE_FROM_BASE*/extends B implements A { }
I'm not a fan of this either, but it's not as super mega broken as the old check
was. here we could omit "implements A" because it's already implied by the base
class.

https://codereview.chromium.org/2340173002/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/checker_test.dart:3129: class C extends B with
X { }
this was broken! even though we had @checked. OUCH.

[Jennifer Messerly, 2016-09-15 21:09:22]

friendly ping

[Leaf, 2016-09-16 00:19:02]

lgtm

[Jennifer Messerly, 2016-09-16 23:04:25]

Description was changed from

==========
address #25232 in strong mode (dart1 behavior unchanged)
==========

to

==========
address #25232 in strong mode (dart1 behavior unchanged)

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0713345b34b996213fd59819b6a8fd460169c062
==========

[Jennifer Messerly, 2016-09-16 23:04:26]

Committed patchset #3 (id:40001) manually as
0713345b34b996213fd59819b6a8fd460169c062 (presubmit successful).