Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 2340133005: Merge M54: Support serving offline page by offline ID (Closed)

Created:
4 years, 3 months ago by jianli
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Merge M54: Support serving offline page by offline ID Review-Url: https://codereview.chromium.org/2322833002 Cr-Commit-Position: refs/heads/master@{#418089} (cherry picked from commit d28e413d6a8607db4f82b5e2dc35c58bea543098) BUG=643404 TEST=new tests added Committed: https://chromium.googlesource.com/chromium/src/+/1becb232faf7661a17d5a14b4ba2a0d4e072c5ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -148 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_interceptor.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_interceptor.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_job.h View 4 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_job.cc View 14 chunks +176 lines, -53 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc View 22 chunks +129 lines, -37 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_tab_helper.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + chrome/test/data/offline_pages/hello.mhtml View 2 chunks +2 lines, -2 lines 0 comments Download
M components/offline_pages/downloads/download_ui_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/downloads/download_ui_adapter.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.h View 5 chunks +9 lines, -1 line 0 comments Download
M components/offline_pages/offline_page_model_impl.cc View 14 chunks +24 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jianli
4 years, 3 months ago (2016-09-16 21:14:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1becb232faf7661a17d5a14b4ba2a0d4e072c5ca.

Powered by Google App Engine
This is Rietveld 408576698