Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2340133004: Make Sk2DPathEffect thread safe. (Closed)

Created:
4 years, 3 months ago by bungeman-skia
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make Sk2DPathEffect thread safe. SkPathEffects must be thread safe, but SkMatrix is only thread safe if the type mask has already been computed. The constructor for Sk2DPathEffect is currently making the call to 'invert' which sets the type mask, but it is being called with the passed matrix as opposed to the local copy. BUG=skia:5765 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340133004 Committed: https://skia.googlesource.com/skia/+/6c3baa66fa38349917783dde1ff2ee21684619fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/effects/Sk2DPathEffect.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
bungeman-skia
Turns out this one can be 'easily' fixed.
4 years, 3 months ago (2016-09-16 13:35:37 UTC) #6
reed1
lgtm
4 years, 3 months ago (2016-09-16 13:49:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340133004/1
4 years, 3 months ago (2016-09-16 13:55:30 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 14:21:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6c3baa66fa38349917783dde1ff2ee21684619fb

Powered by Google App Engine
This is Rietveld 408576698