Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issue 2340133003: More NoGPU compile fixes (Closed)

Created:
4 years, 3 months ago by Brian Osman
Modified:
4 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

More NoGPU compile fixes I can now build 'most' with skia_gpu=0 on my machine. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340133003 Committed: https://skia.googlesource.com/skia/+/9f1f6e2c28066c7d7ff26727ce7d7504c7d032bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M bench/ImageCacheBudgetBench.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M bench/nanobench.cpp View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Brian Osman
4 years, 3 months ago (2016-09-15 15:02:41 UTC) #4
borenet
LGTM
4 years, 3 months ago (2016-09-15 15:03:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340133003/1
4 years, 3 months ago (2016-09-15 15:05:08 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 15:33:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9f1f6e2c28066c7d7ff26727ce7d7504c7d032bd

Powered by Google App Engine
This is Rietveld 408576698