Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2340133002: Clean up unused SkPictureRecorder::optimizeFor() (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
djsollen, mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up unused SkPictureRecorder::optimizeFor() Don't worry about the failing Shield bot... unrelated experiment. It's failing at head. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340133002 NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/c518a76105ce10f06e117697f72e774eef355265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -56 lines) Patch
M include/core/SkPictureRecorder.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 4 chunks +0 lines, -51 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
mtklein_C
4 years, 3 months ago (2016-09-14 22:04:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340133002/1
4 years, 3 months ago (2016-09-14 22:04:13 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-14 22:04:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/13821)
4 years, 3 months ago (2016-09-14 22:06:23 UTC) #12
djsollen
lgtm
4 years, 3 months ago (2016-09-15 03:11:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340133002/1
4 years, 3 months ago (2016-09-15 11:28:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340133002/1
4 years, 3 months ago (2016-09-15 11:41:49 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 11:43:06 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c518a76105ce10f06e117697f72e774eef355265

Powered by Google App Engine
This is Rietveld 408576698