Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2340113003: [layoutng] Make sure to update m_isSelfCollapsing after ng layout (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Make sure to update m_isSelfCollapsing after ng layout This will otherwise cause assertion failures on many pages. We could also compute this in ng code during margin collapsing and just set it on the old object, but I'm not sure that would be worth it. This and https://codereview.chromium.org/2337763005/ fixes most (but not all) of the assertion failures during legacy/ng interop. R=ikilpatrick@chromium.org,eae@chromium.org,glebl@chromium.org BUG=635619 Committed: https://crrev.com/2eacf266f015eca06c70449f397d973bad57ae68 Cr-Commit-Position: refs/heads/master@{#418703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
cbiesinger
4 years, 3 months ago (2016-09-14 21:02:20 UTC) #1
ikilpatrick
lgtm
4 years, 3 months ago (2016-09-14 21:04:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340113003/1
4 years, 3 months ago (2016-09-14 21:17:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 22:44:17 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2eacf266f015eca06c70449f397d973bad57ae68 Cr-Commit-Position: refs/heads/master@{#418703}
4 years, 3 months ago (2016-09-14 22:46:24 UTC) #10
eae
4 years, 3 months ago (2016-09-15 09:26:16 UTC) #11
Message was sent while issue was closed.
Nice! LGTM

Powered by Google App Engine
This is Rietveld 408576698