Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: components/update_client/configurator.h

Issue 2340113002: Inject the prodid for the extensions and component updaters. (Closed)
Patch Set: Fix iOS broken build. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/update_client/configurator.h
diff --git a/components/update_client/configurator.h b/components/update_client/configurator.h
index e547d955a8210e922a0066acf39489bf736b893f..1161ef45d336aead571cbe0a87c20923af868964 100644
--- a/components/update_client/configurator.h
+++ b/components/update_client/configurator.h
@@ -58,6 +58,11 @@ class Configurator : public base::RefCountedThreadSafe<Configurator> {
// disabled. Similarly, these URLs have a fall back behavior too.
virtual std::vector<GURL> PingUrl() const = 0;
+ // The ProdId is used as a prefix in some of the version strings which appear
+ // in the protocol requests. Possible values include "chrome", "chromecrx",
+ // "chromium", and "unknown".
asargent_no_longer_on_chrome 2016/09/15 15:58:47 nit: looks like this can be "chromiumcrx" instead
Sorin Jianu 2016/09/15 16:13:40 Done.
+ virtual std::string GetProdId() const = 0;
+
// Version of the application. Used to compare the component manifests.
virtual base::Version GetBrowserVersion() const = 0;
« no previous file with comments | « chrome/browser/extensions/updater/chrome_update_client_config.cc ('k') | components/update_client/ping_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698