Inject the prodid for the extensions and component updaters.

Inject the prodid for the extensions and component updaters.

This allows both updaters to use specific and correct prodids when
reporting the "version" in the update check and ping  requests.

BUG=641126
Committed: https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f
Cr-Commit-Position: refs/heads/master@{#419529}

[Sorin Jianu, 2016-09-14 20:21:26]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 20:21:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 20:36:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 20:36:21]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Sorin Jianu, 2016-09-15 00:09:06]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 00:09:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sorin Jianu, 2016-09-15 00:09:54]

Description was changed from

==========
Inject the prodid for the extensions and component updaters.

This allows both updaters to use specific and correct prodids when
reporting the "version" in the update check and ping  requests.

BUG=641126
==========

to

==========
Inject the prodid for the extensions and component updaters.

This allows both updaters to use specific and correct prodids when
reporting the "version" in the update check and ping  requests.

BUG=641126
==========

[Sorin Jianu, 2016-09-15 00:09:54]

sorin@chromium.org changed reviewers:
+ asargent@chromium.org, sdefresne@chromium.org, waffles@chromium.org

[commit-bot: I haz the power, 2016-09-15 00:25:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 00:25:11]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Sorin Jianu, 2016-09-15 00:33:08]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 00:33:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sorin Jianu, 2016-09-15 01:03:47]

I need owners' approval please for the paths under ios and extensions.

Thank you so much!

[commit-bot: I haz the power, 2016-09-15 02:05:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 02:05:58]

Dry run: This issue passed the CQ dry run.

[asargent_no_longer_on_chrome, 2016-09-15 15:58:47]

lgtm

https://codereview.chromium.org/2340113002/diff/40001/components/update_clien...
File components/update_client/configurator.h (right):

https://codereview.chromium.org/2340113002/diff/40001/components/update_clien...
components/update_client/configurator.h:63: // "chromium", and "unknown".
nit: looks like this can be "chromiumcrx" instead of (or in addition to)
"chromium"

https://cs.chromium.org/chromium/src/components/update_client/update_query_pa...

[Sorin Jianu, 2016-09-15 16:13:40]

Thank you Antony!

https://codereview.chromium.org/2340113002/diff/40001/components/update_clien...
File components/update_client/configurator.h (right):

https://codereview.chromium.org/2340113002/diff/40001/components/update_clien...
components/update_client/configurator.h:63: // "chromium", and "unknown".
On 2016/09/15 15:58:47, Antony Sargent wrote:
> nit: looks like this can be "chromiumcrx" instead of (or in addition to)
> "chromium"
> 
>
https://cs.chromium.org/chromium/src/components/update_client/update_query_pa...

Done.

[waffles, 2016-09-15 18:14:12]

lgtm

https://codereview.chromium.org/2340113002/diff/60001/components/update_clien...
File components/update_client/configurator.h (right):

https://codereview.chromium.org/2340113002/diff/60001/components/update_clien...
components/update_client/configurator.h:63: // "chromium", "chromiumcrx", and
"unknown".
(FWIW, "chromium" is not a possible value.)

[Sorin Jianu, 2016-09-15 18:29:26]

Thank you!

[Sorin Jianu, 2016-09-16 15:55:25]

sorin@chromium.org changed reviewers:
+ blundell@chromium.org, droger@chromium.org

[Sorin Jianu, 2016-09-16 15:56:06]

Please, I need an owner's review for the change under the iOS path, thank you!

[blundell, 2016-09-18 17:28:48]

I'm not an OWNER of //ios.

[droger, 2016-09-19 08:34:44]

LGTM

[sdefresne, 2016-09-19 09:38:47]

lgtm

[sdefresne, 2016-09-19 09:39:57]

On 2016/09/19 09:38:47, sdefresne wrote:
> lgtm

Sorry for missing this CL, it ended up in my watchlist and as I was not
mentioned in the ping, I didn't notice my review was requested.

[Sorin Jianu, 2016-09-19 18:15:46]

The CQ bit was checked by sorin@chromium.org

[Sorin Jianu, 2016-09-19 18:15:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org, waffles@chromium.org
Link to the patchset: https://codereview.chromium.org/2340113002/#ps80001
(title: "Remove "chromium" as a possible value in comment.")

[commit-bot: I haz the power, 2016-09-19 18:16:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:23:32]

Description was changed from

==========
Inject the prodid for the extensions and component updaters.

This allows both updaters to use specific and correct prodids when
reporting the "version" in the update check and ping  requests.

BUG=641126
==========

to

==========
Inject the prodid for the extensions and component updaters.

This allows both updaters to use specific and correct prodids when
reporting the "version" in the update check and ping  requests.

BUG=641126
==========

[commit-bot: I haz the power, 2016-09-19 19:23:33]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-19 21:03:02]

Description was changed from

==========
Inject the prodid for the extensions and component updaters.

This allows both updaters to use specific and correct prodids when
reporting the "version" in the update check and ping  requests.

BUG=641126
==========

to

==========
Inject the prodid for the extensions and component updaters.

This allows both updaters to use specific and correct prodids when
reporting the "version" in the update check and ping  requests.

BUG=641126

Committed: https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f
Cr-Commit-Position: refs/heads/master@{#419529}
==========

[commit-bot: I haz the power, 2016-09-19 21:03:03]

Patchset 5 (id:??) landed as
https://crrev.com/3a4bb4878548bd119d990b5c37b15f9a11ece00f
Cr-Commit-Position: refs/heads/master@{#419529}