Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 23401002: Fix the CPU feature detection. (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix the CPU feature detection. Move all of the CPU detection logic to the CPU class, and make all other code use the CPU class for feature detection. This also fixes the ARM CPU feature detection logic, which was based on fragile string search in /proc/cpuinfo. Now we use ELF hwcaps if available, falling back to sane(!!) parsing of /proc/cpuinfo for CPU features. The ia32 and x64 code was also cleaned up to make it usable outside the assembler. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16315

Patch Set 1 #

Patch Set 2 : Fix compilation on Mac OS X. #

Patch Set 3 : Improve cpuinfo parsing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+624 lines, -469 lines) Patch
M src/arm/assembler-arm.cc View 2 chunks +15 lines, -12 lines 0 comments Download
M src/cpu.h View 3 chunks +81 lines, -6 lines 0 comments Download
A src/cpu.cc View 1 2 1 chunk +446 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +16 lines, -69 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/platform.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/platform-linux.cc View 2 chunks +0 lines, -187 lines 0 comments Download
M src/platform-nullos.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/platform-posix.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/v8globals.h View 1 chunk +0 lines, -21 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +17 lines, -84 lines 0 comments Download
M test/cctest/cctest.gyp View 3 chunks +3 lines, -0 lines 0 comments Download
A + test/cctest/test-cpu.cc View 1 2 1 chunk +17 lines, -28 lines 0 comments Download
A + test/cctest/test-cpu-ia32.cc View 1 chunk +10 lines, -15 lines 0 comments Download
A + test/cctest/test-cpu-x64.cc View 1 chunk +13 lines, -12 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +1 line, -5 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
7 years, 4 months ago (2013-08-23 12:16:08 UTC) #1
Sven Panne
LGTM. 70's-style string processing FTW! ;-)
7 years, 4 months ago (2013-08-26 07:36:02 UTC) #2
Benedikt Meurer
7 years, 4 months ago (2013-08-26 09:38:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r16315 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698