Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2340093002: Revert of Enable the ninja up-to-date check for Android builders (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Enable the ninja up-to-date check for Android builders (patchset #1 id:1 of https://codereview.chromium.org/2338203004/ ) Reason for revert: Broke cronet builders. Original issue's description: > Enable the ninja up-to-date check for Android builders > > BUG=646165 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/9ef12eb44ae227823398dc0604213fadae4e1655 TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=646165 Committed: https://chromium.googlesource.com/chromium/tools/build/+/c97a211b5b7815d9d601760f6119a3156c7e458d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -76 lines) Patch
M scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/chromium_config.py View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/coverage_builder_basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_refs.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_try_builder_basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/restart_usb_builder_basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/cronet/example.expected/gn_test.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/cronet/example.expected/local_test.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/chromium_android_Android_x64_Builder__dbg__fail_check_licenses.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_MIPS_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_x64_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_x86_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_arm64_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_client_v8_fyi_Android_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_arm64_perf_bisect_builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_perf_bisect_builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/dynamic_swarmed_gn_instrumentation_test.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_Android.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Cronet_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_MIPS_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_N5X_Swarm_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Swarm_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm64_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_x64_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_android_Android_x86_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Asan_Builder_Tests__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Cloud_Tests.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Android_Release__Nexus_5X_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Android_Release__Nexus_5_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Android_Release__Nexus_6P_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Android_Release__Nexus_6_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Android_Release__Nexus_9_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Android_Release__Pixel_C_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Arm64_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_Clang_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Cast_Android__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_Android_Builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Builder_ARM64__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Android_Builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_V8_Android_GN__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_archive_rel_ng.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_blink_rel.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_coverage.json View 2 chunks +0 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_cast_shell_android.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_v8_v8_android_chromium_gn_dbg.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_builder_asan.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_kitkat_builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_lollipop_builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_perf.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_mips_builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_tester.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_x86_builder.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/android_cronet_x86_builder__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/cronet_try.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/cronet.expected/local_test.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/dart/dartium_android_builder.expected/dartium_builder_basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/dart/dartium_android_builder.expected/dartium_builder_git.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/emulator.expected/Android_Tests__x86_emulator__test_basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/emulator.expected/Android_Tests__x86_emulator__test_fail.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Android_deterministic.json View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
agrieve
Created Revert of Enable the ninja up-to-date check for Android builders
4 years, 3 months ago (2016-09-14 18:58:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340093002/1
4 years, 3 months ago (2016-09-14 18:58:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/c97a211b5b7815d9d601760f6119a3156c7e458d
4 years, 3 months ago (2016-09-14 18:58:50 UTC) #5
Dirk Pranke
lgtm.
4 years, 3 months ago (2016-09-14 19:00:24 UTC) #6
agrieve
4 years, 3 months ago (2016-09-14 19:28:39 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2343563003/ by agrieve@chromium.org.

The reason for reverting is: Fixed cronet targets here:
https://codereview.chromium.org/2341903002.

Powered by Google App Engine
This is Rietveld 408576698