|
|
Created:
4 years, 3 months ago by gab Modified:
4 years, 3 months ago Reviewers:
Roger Tawa OOO till Jul 10th CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake TestRLZTrackerDelegate's SequencedWorkerPool multi-threaded.
BUG=646443
Committed: https://crrev.com/fe6ad6084dd2680ce5c5247b627bdd9dbe7c27ff
Cr-Commit-Position: refs/heads/master@{#418674}
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 16 (10 generated)
gab@chromium.org changed reviewers: + rogerta@chromium.org
Roger PTaL, thanks!
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
RLZ uses a worker pool token to serialize things, so that still works right? If so, then lgtm
On 2016/09/14 20:04:30, Roger Tawa wrote: > RLZ uses a worker pool token to serialize things, so that still works right? If > so, then lgtm Right, so in practice it won't change anything for this test, it's just that we want to remove the notion that it's possible for a SequencedWorkerPool to guarantee thread-affinity.
The CQ bit was checked by gab@chromium.org to run a CQ dry run
The CQ bit was unchecked by gab@chromium.org
The CQ bit was checked by gab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rogerta@chromium.org Link to the patchset: https://codereview.chromium.org/2340063003/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make TestRLZTrackerDelegate's SequencedWorkerPool multi-threaded. BUG=646443 ========== to ========== Make TestRLZTrackerDelegate's SequencedWorkerPool multi-threaded. BUG=646443 Committed: https://crrev.com/fe6ad6084dd2680ce5c5247b627bdd9dbe7c27ff Cr-Commit-Position: refs/heads/master@{#418674} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fe6ad6084dd2680ce5c5247b627bdd9dbe7c27ff Cr-Commit-Position: refs/heads/master@{#418674} |