Add UMA Description for OmniboxMobileSearch

Add UMA Description for OmniboxMobileSearch

Right now people are assuming it means something it doesn't.

BUG=

Committed: https://crrev.com/d400bcaea24ad23ce3499eb09a36329821b92073
Cr-Commit-Position: refs/heads/master@{#419516}

[Mark P, 2016-09-14 18:26:22]

Description was changed from

==========
Add UMA Description for OmniboxMobileSearch

Right now people are assuming it means something it doesn't.

BUG=
==========

to

==========
Add UMA Description for OmniboxMobileSearch

Right now people are assuming it means something it doesn't.

BUG=
==========

[Mark P, 2016-09-14 18:26:22]

mpearson@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Mark P, 2016-09-14 18:28:23]

Please take a look at this and help me write a better description.

I'm confused by the "if" statement here that indicates that this metric isn't
recorded on one path.
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...
I think my tentative description might be incomplete.

--mark

[rkaplow, 2016-09-14 18:59:14]

rkaplow@chromium.org changed reviewers:
+ rkaplow@chromium.org

[rkaplow, 2016-09-14 18:59:14]

If this counts when someone uses omnibox to go to an autocompleted entry - I
don't think this is a good name from the metric. Could we rename it
MobileOmniboxNavigation?

[Ted C, 2016-09-14 23:05:58]

On 2016/09/14 18:59:14, rkaplow wrote:
> If this counts when someone uses omnibox to go to an autocompleted entry - I
> don't think this is a good name from the metric. Could we rename it
> MobileOmniboxNavigation?


Yeah, this is logged for any navigation from the omnibox (search, nav
suggest, voice, maybe others?).  Definitely not restricted to just search.

The "if statement" you pointed out Mark is that if you clear the text
and hit enter then we just reset back to the previous URL w/o any navigation.

[Mark P, 2016-09-15 23:01:10]

On 2016/09/14 23:05:58, Ted C wrote:
> On 2016/09/14 18:59:14, rkaplow wrote:
> > If this counts when someone uses omnibox to go to an autocompleted entry - I
> > don't think this is a good name from the metric. Could we rename it
> > MobileOmniboxNavigation?

I'm happy to change the name.  I wish I had some sense of the number of people
who already know the previous name and would like look at the old one and not
notice it's been deprecated and its counts are decreasing.  The user action has
existed for years...

If we go with a new name, I'd suggest MobileOmniboxUse.

> Yeah, this is logged for any navigation from the omnibox (search, nav
> suggest, voice, maybe others?).  Definitely not restricted to just search.
> 
> The "if statement" you pointed out Mark is that if you clear the text
> and hit enter then we just reset back to the previous URL w/o any navigation.

Ah, thanks for the explanation.

--mark

[rkaplow, 2016-09-16 14:08:37]

On 2016/09/15 23:01:10, Mark P wrote:
> On 2016/09/14 23:05:58, Ted C wrote:
> > On 2016/09/14 18:59:14, rkaplow wrote:
> > > If this counts when someone uses omnibox to go to an autocompleted entry -
I
> > > don't think this is a good name from the metric. Could we rename it
> > > MobileOmniboxNavigation?
> 
> I'm happy to change the name.  I wish I had some sense of the number of people
> who already know the previous name and would like look at the old one and not
> notice it's been deprecated and its counts are decreasing.  The user action
has
> existed for years...
> 
> If we go with a new name, I'd suggest MobileOmniboxUse.
> 
> > Yeah, this is logged for any navigation from the omnibox (search, nav
> > suggest, voice, maybe others?).  Definitely not restricted to just search.
> > 
> > The "if statement" you pointed out Mark is that if you clear the text
> > and hit enter then we just reset back to the previous URL w/o any
navigation.
> 
> Ah, thanks for the explanation.
> 
> --mark

Well, it's up to you guys, but I'd rather save future confusion for a bit of
short term pain. You can leave the current name with a description that points
to the new one

[Mark P, 2016-09-16 21:52:04]

Renamed histogram.  Please take a look.

Once submitted, I'll look to update the bling code as well as internal logs
analysis tools.

--mark

[rkaplow, 2016-09-16 21:54:16]

lgtm

[Ted C, 2016-09-17 04:17:29]

lgtm

[Mark P, 2016-09-19 18:07:49]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2016-09-19 18:07:49]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2340063002/#ps40001
(title: "additional clarification")

[commit-bot: I haz the power, 2016-09-19 18:08:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 18:41:28]

Description was changed from

==========
Add UMA Description for OmniboxMobileSearch

Right now people are assuming it means something it doesn't.

BUG=
==========

to

==========
Add UMA Description for OmniboxMobileSearch

Right now people are assuming it means something it doesn't.

BUG=
==========

[commit-bot: I haz the power, 2016-09-19 18:41:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-19 18:42:40]

Description was changed from

==========
Add UMA Description for OmniboxMobileSearch

Right now people are assuming it means something it doesn't.

BUG=
==========

to

==========
Add UMA Description for OmniboxMobileSearch

Right now people are assuming it means something it doesn't.

BUG=

Committed: https://crrev.com/d400bcaea24ad23ce3499eb09a36329821b92073
Cr-Commit-Position: refs/heads/master@{#419516}
==========

[commit-bot: I haz the power, 2016-09-19 18:42:41]

Patchset 3 (id:??) landed as
https://crrev.com/d400bcaea24ad23ce3499eb09a36329821b92073
Cr-Commit-Position: refs/heads/master@{#419516}