Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2339983005: GN: link executables with -rdynamic on Linux. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: link executables with -rdynamic on Linux. -rdynamic makes sure the executable exposes all its symbols, which allows things like DM's built-in stack trace dumper to show symbols instead of just addresses. We do this in GYP too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339983005 Committed: https://skia.googlesource.com/skia/+/a846c7223c531a634a549e7e6ed7d28eeec95bef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M gn/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
mtklein_C
4 years, 3 months ago (2016-09-15 17:12:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339983005/1
4 years, 3 months ago (2016-09-15 17:12:31 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-15 17:12:32 UTC) #7
jcgregorio
lgtm
4 years, 3 months ago (2016-09-15 17:14:14 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:44:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a846c7223c531a634a549e7e6ed7d28eeec95bef

Powered by Google App Engine
This is Rietveld 408576698