Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2339983003:
Worker: Check whether forcible termination happened before processing a task (Closed)
|
Created:
4 years, 3 months ago by nhiroki Modified:
4 years, 3 months ago Reviewers:
yhirano CC:
chromium-reviews, shimazu+worker_chromium.org, falken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, blink-worker-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWorker: Check whether forcible termination happened before processing a task
Running a task on a worker thread after forcible termination may cause a crash
because of an access to an empty handle returned by V8 API.
BUG=646861
Committed: https://crrev.com/ce4019623117ec2b7eb8b5d5ce6af590f5e198b9
Cr-Commit-Position: refs/heads/master@{#419065}
Patch Set 1 #
Total comments: 2
Patch Set 2 : remove prepareForShutdown call from didProcessTask #Messages
Total messages: 21 (14 generated)
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Worker: Prepare for shutdown as soon as possible after forcible termination Running a task on a worker thread after forcible termination may cause a crash because of an access to terminated Isolate. BUG=646861 ========== to ========== Worker: Prepare for shutdown as soon as possible after forcible termination Running a task on a worker thread after forcible termination may cause a crash because of an access to an empty handle returned by V8 API. BUG=646861 ==========
nhiroki@chromium.org changed reviewers: + yhirano@chromium.org
PTAL, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2339983003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/workers/WorkerThread.cpp (right): https://codereview.chromium.org/2339983003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/workers/WorkerThread.cpp:146: // ask objects in the thread to stop working as soon as possible. Can we remove this branch?
Description was changed from ========== Worker: Prepare for shutdown as soon as possible after forcible termination Running a task on a worker thread after forcible termination may cause a crash because of an access to an empty handle returned by V8 API. BUG=646861 ========== to ========== Worker: Check whether forcible termination happened before processing a task Running a task on a worker thread after forcible termination may cause a crash because of an access to an empty handle returned by V8 API. BUG=646861 ==========
Description was changed from ========== Worker: Check whether forcible termination happened before processing a task Running a task on a worker thread after forcible termination may cause a crash because of an access to an empty handle returned by V8 API. BUG=646861 ========== to ========== Worker: Check whether forcible termination happened before processing a task Running a task on a worker thread after forcible termination may cause a crash because of an access to an empty handle returned by V8 API. BUG=646861 ==========
Thank you. Updated. https://codereview.chromium.org/2339983003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/workers/WorkerThread.cpp (right): https://codereview.chromium.org/2339983003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/workers/WorkerThread.cpp:146: // ask objects in the thread to stop working as soon as possible. On 2016/09/15 08:32:12, yhirano (slow) wrote: > Can we remove this branch? Done.
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by nhiroki@chromium.org
The CQ bit was checked by nhiroki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Worker: Check whether forcible termination happened before processing a task Running a task on a worker thread after forcible termination may cause a crash because of an access to an empty handle returned by V8 API. BUG=646861 ========== to ========== Worker: Check whether forcible termination happened before processing a task Running a task on a worker thread after forcible termination may cause a crash because of an access to an empty handle returned by V8 API. BUG=646861 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Worker: Check whether forcible termination happened before processing a task Running a task on a worker thread after forcible termination may cause a crash because of an access to an empty handle returned by V8 API. BUG=646861 ========== to ========== Worker: Check whether forcible termination happened before processing a task Running a task on a worker thread after forcible termination may cause a crash because of an access to an empty handle returned by V8 API. BUG=646861 Committed: https://crrev.com/ce4019623117ec2b7eb8b5d5ce6af590f5e198b9 Cr-Commit-Position: refs/heads/master@{#419065} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ce4019623117ec2b7eb8b5d5ce6af590f5e198b9 Cr-Commit-Position: refs/heads/master@{#419065} |
