Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html

Issue 2339983002: [css-grid] Remove the 2x computation of row sizes w/ indefinite heights (Closed)
Patch Set: Rebased patch for landing v2 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/PerformanceTests/Layout/nested-grid.html » ('j') | third_party/WebKit/PerformanceTests/Layout/nested-grid.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html
index 75fbca0ce5b7ab3dc15dfced072b7289d1d7821f..846071b00f16316047ef10c4f5577814c85c2dbe 100644
--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html
@@ -52,15 +52,15 @@
</div>
<div class="grid max-content max-height-35" data-expected-width="40" data-expected-height="35">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="35">XX XXX XX XXX</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX XXX XX XXX</div>
</div>
<div class="grid max-content max-height-min-content" data-expected-width="40" data-expected-height="0">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">XX XXX X</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX XXX X</div>
</div>
<div class="grid max-height-min-content" data-expected-width="40" data-expected-height="0">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">XX XXX</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX XXX</div>
</div>
<div class="grid max-content max-height-fill-available" data-expected-width="40" data-expected-height="100">
@@ -130,11 +130,11 @@
</div>
<div class="grid itemsStart min-content" data-expected-width="40" data-expected-height="0">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">XX XX XX</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX XX XX</div>
</div>
<div class="grid itemsStart min-content min-height-50" data-expected-width="40" data-expected-height="50">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="50">XX X</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX X</div>
</div>
<div class="grid itemsStart min-content min-height-fit-content" data-expected-width="40" data-expected-height="100">
@@ -148,11 +148,11 @@
</div>
<div class="grid itemsStart min-content min-height-min-content" data-expected-width="40" data-expected-height="0">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">XX XXX</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX XXX</div>
</div>
<div class="grid itemsStart min-content min-height-35" data-expected-width="40" data-expected-height="35">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="35">XX XX</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX XX</div>
</div>
<div class="grid itemsStart min-content min-height-max-content" data-expected-width="40" data-expected-height="100">
@@ -160,11 +160,11 @@
</div>
<div class="grid itemsStart min-content min-height-50" data-expected-width="40" data-expected-height="50">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="50">XXXX XXXX XXXX XXXX</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XXXX XXXX XXXX XXXX</div>
</div>
<div class="grid itemsStart min-content max-height-50" data-expected-width="40" data-expected-height="0">
- <div class="sizedToGridArea min-height-fill-available" data-expected-width="40" data-expected-height="50">XXXX X X XXXX</div>
+ <div class="sizedToGridArea min-height-fill-available" data-expected-width="40" data-expected-height="100">XXXX X X XXXX</div>
</div>
<br>
@@ -207,7 +207,7 @@
<div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">X XXXX X</div>
</div>
<div class="grid itemsStart max-height-min-content" data-expected-width="40" data-expected-height="0">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">XX XX XX</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX XX XX</div>
</div>
<div class="grid itemsStart fit-content" data-expected-width="40" data-expected-height="100">
<div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">X XX X</div>
@@ -228,7 +228,7 @@
<div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XXXX X X</div>
</div>
<div class="grid itemsStart max-height-min-content" data-expected-width="40" data-expected-height="0">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">X XXX XX</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">X XXX XX</div>
</div>
<div class="grid itemsStart fit-content" data-expected-width="40" data-expected-height="100">
<div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX XXX XX X</div>
@@ -237,22 +237,22 @@
<div class="fit-content min-height-50" style="height: 75px;">
<div class="grid itemsStart fill-available" data-expected-width="40" data-expected-height="75">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="75">XX X</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX X</div>
</div>
</div>
<div style="height: 25px;">
<div class="grid itemsStart fit-content" data-expected-width="40" data-expected-height="25">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="25">XX X</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX X</div>
</div>
<div class="grid itemsStart fill-available" data-expected-width="40" data-expected-height="25">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="25">XX X</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX X</div>
</div>
<div class="grid itemsStart fit-content min-height-35" data-expected-width="40" data-expected-height="35">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="35">XX X</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX X</div>
</div>
<div class="grid itemsStart fit-content max-height-min-content" data-expected-width="40" data-expected-height="0">
- <div class="sizedToGridArea" data-expected-width="40" data-expected-height="0">XX X</div>
+ <div class="sizedToGridArea" data-expected-width="40" data-expected-height="100">XX X</div>
</div>
</div>
« no previous file with comments | « no previous file | third_party/WebKit/PerformanceTests/Layout/nested-grid.html » ('j') | third_party/WebKit/PerformanceTests/Layout/nested-grid.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698