Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

Issue 2339973002: Handle exclusive end offsets when translating from flow thread coordinates. (Closed)
Patch Set: Documentation Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h
diff --git a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h
index f49b93e6ddfd7331e2181157cadb94242804cc74..343c8df31e7f31fcfe940378e79304fa4406e281 100644
--- a/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h
+++ b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h
@@ -62,7 +62,7 @@ public:
void resetColumnHeight();
bool recalculateColumnHeight(LayoutMultiColumnSet&);
- LayoutSize flowThreadTranslationAtOffset(LayoutUnit, CoordinateSpaceConversion) const;
+ LayoutSize flowThreadTranslationAtOffset(LayoutUnit, LayoutBox::PageBoundaryRule, CoordinateSpaceConversion) const;
LayoutUnit columnLogicalTopForOffset(LayoutUnit offsetInFlowThread) const;
LayoutPoint visualPointToFlowThreadPoint(const LayoutPoint& visualPoint) const;
LayoutRect fragmentsBoundingBox(const LayoutRect& boundingBoxInFlowThread) const;
@@ -78,13 +78,10 @@ public:
LayoutRect calculateOverflow() const;
- enum ColumnIndexCalculationMode {
- ClampToExistingColumns, // Stay within the range of already existing columns.
- AssumeNewColumns // Allow column indices outside the range of already existing columns.
- };
- unsigned columnIndexAtOffset(LayoutUnit offsetInFlowThread, ColumnIndexCalculationMode = ClampToExistingColumns) const;
+ unsigned columnIndexAtOffset(LayoutUnit offsetInFlowThread, LayoutBox::PageBoundaryRule) const;
// The "CSS actual" value of column-count. This includes overflowing columns, if any.
+ // Returns 1 or greater, never 0.
unsigned actualColumnCount() const;
private:

Powered by Google App Engine
This is Rietveld 408576698