third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp - Issue 2339973002: Handle exclusive end offsets when translating from flow thread coordinates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp

Issue 2339973002: Handle exclusive end offsets when translating from flow thread coordinates. (Closed)

Patch Set: Renamed tests, and fixed typos there. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ColumnBalancer.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h » ('j') | third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp

diff --git a/third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp b/third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp

index 884c70a7fa2b6e93a3446fda02d3cb8518a3c14c..e582db42ac3e93b1ef981988cb65be9d05f83b23 100644

--- a/third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp

+++ b/third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp

@@ -103,7 +103,7 @@ bool FragmentainerIterator::setFragmentainersOfInterest()

// narrow it down even further. The clip rect needs to be relative to the current fragmentainer

// group.

LayoutRect clipRect = m_clipRectInMulticolContainer;

- LayoutSize offset = group.flowThreadTranslationAtOffset(group.logicalTopInFlowThread(), CoordinateSpaceConversion::Visual);

+ LayoutSize offset = group.flowThreadTranslationAtOffset(group.logicalTopInFlowThread(), LayoutBox::AssociateWithFormerPage, CoordinateSpaceConversion::Visual);

clipRect.move(-offset);

unsigned firstFragmentainerInClipRect, lastFragmentainerInClipRect;

group.columnIntervalForVisualRect(clipRect, firstFragmentainerInClipRect, lastFragmentainerInClipRect);

@@ -125,7 +125,7 @@ void FragmentainerIterator::updateOutput()

// Set the physical translation offset.

LayoutUnit fragmentainerLogicalTopInFlowThread = group.logicalTopInFlowThread() + m_currentFragmentainerIndex * group.logicalHeight();

- m_paginationOffset = group.flowThreadTranslationAtOffset(fragmentainerLogicalTopInFlowThread, CoordinateSpaceConversion::Visual);

+ m_paginationOffset = group.flowThreadTranslationAtOffset(fragmentainerLogicalTopInFlowThread, LayoutBox::AssociateWithLatterPage, CoordinateSpaceConversion::Visual);

// Set the overflow clip rect that corresponds to the fragmentainer.

m_clipRectInFlowThread = group.flowThreadPortionOverflowRectAt(m_currentFragmentainerIndex);