Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 2339943002: [turbofan] ARM64: Use zr for zeroing stack slots (Closed)

Created:
4 years, 3 months ago by martyn.capewell
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] ARM64: Use zr for zeroing stack slots When zeroing a floating point stack slot, store the zero register directly, rather than storing zero moved to an FP register. BUG= Committed: https://crrev.com/f84f45f9ca808a0829df76bf9da712d4c1f51ed7 Cr-Commit-Position: refs/heads/master@{#39441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
martyn.capewell
4 years, 3 months ago (2016-09-14 13:59:39 UTC) #2
Benedikt Meurer
Cool stuff. LGTM.
4 years, 3 months ago (2016-09-14 16:48:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339943002/1
4 years, 3 months ago (2016-09-15 09:07:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 09:36:53 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 09:37:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f84f45f9ca808a0829df76bf9da712d4c1f51ed7
Cr-Commit-Position: refs/heads/master@{#39441}

Powered by Google App Engine
This is Rietveld 408576698