[BlobStorage] BlobMemoryController & tests

storage/browser/blob/blob_data_item.h

Index: storage/browser/blob/blob_data_item.h
diff --git a/storage/browser/blob/blob_data_item.h b/storage/browser/blob/blob_data_item.h
index a711a4caf3b3fe4bc969be9e63c87bb33aa79834..4a8e09aca1d89071adcc5156eb7d92574743d4d8 100644
--- a/storage/browser/blob/blob_data_item.h
+++ b/storage/browser/blob/blob_data_item.h
@@ -43,6 +43,15 @@ class STORAGE_EXPORT BlobDataItem : public base::RefCounted<BlobDataItem> {
     friend class base::RefCounted<DataHandle>;
   };
 
+  explicit BlobDataItem(std::unique_ptr<DataElement> item);

[michaeln, 2016/10/11 20:55:23]

do these need to be public? what are the new consumers that need to cons these
up?

the fact that they're private is a good indication to random readers that they
probably won't need to construct these objects themselves (from the point of
view of using the storage lib rather than implementing the storage lib).

[dmurph, 2016/10/13 00:39:29]

Done.

+  BlobDataItem(std::unique_ptr<DataElement> item,
+               const scoped_refptr<DataHandle>& data_handle);
+  BlobDataItem(std::unique_ptr<DataElement> item,
+               const scoped_refptr<DataHandle>& data_handle,
+               disk_cache::Entry* entry,
+               int disk_cache_stream_index,
+               int disk_cache_side_stream_index);
+
   DataElement::Type type() const { return item_->type(); }
   const char* bytes() const { return item_->bytes(); }
   const base::FilePath& path() const { return item_->path(); }
@@ -63,20 +72,14 @@ class STORAGE_EXPORT BlobDataItem : public base::RefCounted<BlobDataItem> {
     return disk_cache_side_stream_index_;
   }
 
+  const scoped_refptr<DataHandle>& data_handle() const { return data_handle_; }
+
  private:
   friend class BlobDataBuilder;
   friend class BlobStorageContext;
   friend class base::RefCounted<BlobDataItem>;
   friend STORAGE_EXPORT void PrintTo(const BlobDataItem& x, ::std::ostream* os);
 
-  explicit BlobDataItem(std::unique_ptr<DataElement> item);
-  BlobDataItem(std::unique_ptr<DataElement> item,
-               const scoped_refptr<DataHandle>& data_handle);
-  BlobDataItem(std::unique_ptr<DataElement> item,
-               const scoped_refptr<DataHandle>& data_handle,
-               disk_cache::Entry* entry,
-               int disk_cache_stream_index,
-               int disk_cache_side_stream_index);
   virtual ~BlobDataItem();
 
   std::unique_ptr<DataElement> item_;