Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: content/browser/blob_storage/blob_async_transport_request_builder_unittest.cc

Issue 2339933004: [BlobStorage] BlobMemoryController & tests (Closed)
Patch Set: Comments, and made task base class for hopefully more simplicity Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/blob_storage/blob_async_transport_request_builder_unittest.cc
diff --git a/content/browser/blob_storage/blob_async_transport_request_builder_unittest.cc b/content/browser/blob_storage/blob_async_transport_request_builder_unittest.cc
index 071a06bb23f97d2f893dc0237644a95f9b7ffa01..61a37b9099b7b0d0d8140396080ff0399aea3d00 100644
--- a/content/browser/blob_storage/blob_async_transport_request_builder_unittest.cc
+++ b/content/browser/blob_storage/blob_async_transport_request_builder_unittest.cc
@@ -15,8 +15,6 @@ namespace storage {
namespace {
const char kNewUUID[] = "newUUID";
-const base::FilePath kFuturePopulatingFilePath = base::FilePath::FromUTF8Unsafe(
- std::string(BlobDataBuilder::kAppendFutureFileTemporaryFileName));
const char kFakeBlobUUID[] = "fakeBlob";
void AddMemoryItem(size_t length, std::vector<DataElement>* out) {
@@ -87,7 +85,7 @@ TEST(BlobAsyncTransportRequestBuilderTest, TestLargeBlockToFile) {
memory_item_request.message);
BlobDataBuilder expected_builder(kNewUUID);
- expected_builder.AppendFile(kFuturePopulatingFilePath, 0, 305,
+ expected_builder.AppendFile(BlobDataBuilder::GetFutureFileItemPath(0), 0, 305,
base::Time::FromDoubleT(0));
EXPECT_EQ(expected_builder, builder);
}
@@ -131,11 +129,11 @@ TEST(BlobAsyncTransportRequestBuilderTest, TestLargeBlockToFiles) {
memory_item_request.message);
BlobDataBuilder expected_builder(kNewUUID);
- expected_builder.AppendFile(kFuturePopulatingFilePath, 0, 400,
+ expected_builder.AppendFile(BlobDataBuilder::GetFutureFileItemPath(0), 0, 400,
base::Time::FromDoubleT(0));
- expected_builder.AppendFile(kFuturePopulatingFilePath, 0, 400,
+ expected_builder.AppendFile(BlobDataBuilder::GetFutureFileItemPath(1), 0, 400,
base::Time::FromDoubleT(0));
- expected_builder.AppendFile(kFuturePopulatingFilePath, 0, 200,
+ expected_builder.AppendFile(BlobDataBuilder::GetFutureFileItemPath(2), 0, 200,
base::Time::FromDoubleT(0));
EXPECT_EQ(expected_builder, builder);
}
« no previous file with comments | « no previous file | content/browser/blob_storage/blob_data_builder_unittest.cc » ('j') | storage/browser/blob/blob_data_builder.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698