Disentangle gyp and gn files

Disentangle gyp and gn files

BUG=chromium:646794
R=machenbach@chromium.org

Committed: https://crrev.com/6a716ae9a46612a30c8855be682131223c0fe8e1
Cr-Commit-Position: refs/heads/master@{#39427}

[jochen (gone - plz use gerrit), 2016-09-14 13:57:24]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 13:57:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-09-14 14:00:11]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 14:00:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 14:17:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 14:17:57]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/12733)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[jochen (gone - plz use gerrit), 2016-09-14 14:39:39]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 14:39:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-09-14 14:40:18]

jochen@chromium.org changed reviewers:
+ hpayer@chromium.org

[jochen (gone - plz use gerrit), 2016-09-14 14:40:18]

+hannes

this test can't be threaded, as another test might leave garbage array buffers
on the heap, and the gc triggered here will then change the amount of external
memory in unexpected ways

[commit-bot: I haz the power, 2016-09-14 15:10:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 15:10:48]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2016-09-14 17:13:49]

lgtm

[Michael Achenbach, 2016-09-14 18:35:34]

hmm - is this urgent? Im worried about two things:

1. Developers might not get aware of this change and, used to the current state,
add a file to gyp only - leading to silent skipping of their test. Maybe we
should deliver a reverse tool that infers the files for gyp from gn? Or do this
change very close to the point were we delete the gyp files?

2. Why did this change make the Threading test fail? Did the order of input
files change and is the test sensitive to that order?

[jochen (gone - plz use gerrit), 2016-09-14 18:41:47]

On 2016/09/14 at 18:35:34, machenbach wrote:
> hmm - is this urgent? Im worried about two things:
> 
> 1. Developers might not get aware of this change and, used to the current
state, add a file to gyp only - leading to silent skipping of their test. Maybe
we should deliver a reverse tool that infers the files for gyp from gn? Or do
this change very close to the point were we delete the gyp files?


the thing is that the gyp files already started to diverge (e.g. wasm module
loader exists in gn but not in gyp), and I would really like to get everybody to
use gn only

> 
> 2. Why did this change make the Threading test fail? Did the order of input
files change and is the test sensitive to that order?

the order changed, yes, which changes the order of static initializers which the
threading test uses to configure itself.

[Michael Achenbach, 2016-09-14 18:55:43]

fine - lgtm

we should write a PSA to v8-dev, notifying folks to keep both files up-to-date
again.

More sophisticated infrastructure, like a presubmit check, is probably not worth
it.

We could also enhance this
https://cs.chromium.org/chromium/src/v8/tools/verify_source_deps.py a bit for
GN.

[jochen (gone - plz use gerrit), 2016-09-14 18:59:14]

will send an PSA

[jochen (gone - plz use gerrit), 2016-09-14 18:59:17]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-09-14 18:59:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 19:02:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-14 19:02:46]

Description was changed from

==========
Disentangle gyp and gn files

BUG=chromium:646794
R=machenbach@chromium.org
==========

to

==========
Disentangle gyp and gn files

BUG=chromium:646794
R=machenbach@chromium.org

Committed: https://crrev.com/6a716ae9a46612a30c8855be682131223c0fe8e1
Cr-Commit-Position: refs/heads/master@{#39427}
==========

[commit-bot: I haz the power, 2016-09-14 19:02:47]

Patchset 3 (id:??) landed as
https://crrev.com/6a716ae9a46612a30c8855be682131223c0fe8e1
Cr-Commit-Position: refs/heads/master@{#39427}