Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: git_cl.py

Issue 2339903002: git_cl: update outdated TODOs. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 2d9ced9689664dafe547ddd61bc5835e26b5d528..2fb7cdd6146e0c289f092eaf043b486644ab2e70 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -3079,9 +3079,9 @@ def GetRietveldCodereviewSettingsInteractively():
def CMDconfig(parser, args):
"""Edits configuration for this tree."""
- print('WARNING: git cl config works for Rietveld only.\n'
- 'For Gerrit, see http://crbug.com/603116.')
- # TODO(tandrii): add Gerrit support as part of http://crbug.com/603116.
+ print('WARNING: git cl config works for Rietveld only')
+ # TODO(tandrii): remove this once we switch to Gerrit.
+ # See bugs http://crbug.com/637561 and http://crbug.com/600469.
parser.add_option('--activate-update', action='store_true',
help='activate auto-updating [rietveld] section in '
'.git/config')
@@ -4393,8 +4393,6 @@ review to be closed, without actually landing upstream. If you choose to
proceed, please verify that the commit lands upstream as expected."""
print(message)
ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
- # TODO(tandrii): kill this post SVN migration with
- # https://codereview.chromium.org/2076683002
print('WARNING: chrome infrastructure is migrating SVN repos to Git.\n'
'Please let us know of this project you are committing to:'
' http://crbug.com/600451')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698