A postmortem minidump dumper utility

A postmortem minidump dumper utility

BUG=620813
Committed: https://crrev.com/0c23a7f9f36c34e897fe648e62702195e7334e40
Cr-Commit-Position: refs/heads/master@{#418980}

[manzagop (departed), 2016-09-14 14:22:51]

Patchset #1 (id:1) has been deleted

[manzagop (departed), 2016-09-14 14:23:36]

manzagop@chromium.org changed reviewers:
+ siggi@chromium.org

[manzagop (departed), 2016-09-14 14:23:36]

Useful utility for debugging. Please have a look!

[Sigurður Ásgeirsson, 2016-09-14 15:57:26]

lgtm

https://codereview.chromium.org/2339873003/diff/20001/components/browser_watc...
File components/browser_watcher/dump_postmortem_minidump_main_win.cc (right):

https://codereview.chromium.org/2339873003/diff/20001/components/browser_watc...
components/browser_watcher/dump_postmortem_minidump_main_win.cc:68:
MINIDUMP_HEADER header = {};
nit: a Todo to do this with CP?

[manzagop (departed), 2016-09-14 15:59:32]

Description was changed from

==========
A postmortem minidump dumper utility

BUG=
==========

to

==========
A postmortem minidump dumper utility

BUG=620813
==========

[manzagop (departed), 2016-09-14 18:19:06]

Thanks for the review! Will submit once https://crrev.com/2327043002 gets in.

https://codereview.chromium.org/2339873003/diff/20001/components/browser_watc...
File components/browser_watcher/dump_postmortem_minidump_main_win.cc (right):

https://codereview.chromium.org/2339873003/diff/20001/components/browser_watc...
components/browser_watcher/dump_postmortem_minidump_main_win.cc:68:
MINIDUMP_HEADER header = {};
On 2016/09/14 15:57:26, Sigurður Ásgeirsson wrote:
> nit: a Todo to do this with CP?

Done.

[manzagop (departed), 2016-09-15 16:03:24]

The CQ bit was checked by manzagop@chromium.org

[manzagop (departed), 2016-09-15 16:03:25]

The patchset sent to the CQ was uploaded after l-g-t-m from siggi@chromium.org
Link to the patchset: https://codereview.chromium.org/2339873003/#ps60001
(title: "Merge")

[commit-bot: I haz the power, 2016-09-15 16:03:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 16:51:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 16:51:41]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[manzagop (departed), 2016-09-15 20:24:55]

The CQ bit was checked by manzagop@chromium.org

[manzagop (departed), 2016-09-15 20:24:56]

The patchset sent to the CQ was uploaded after l-g-t-m from siggi@chromium.org
Link to the patchset: https://codereview.chromium.org/2339873003/#ps80001
(title: "Incorrect use of fprintf")

[commit-bot: I haz the power, 2016-09-15 20:25:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:27:49]

Description was changed from

==========
A postmortem minidump dumper utility

BUG=620813
==========

to

==========
A postmortem minidump dumper utility

BUG=620813
==========

[commit-bot: I haz the power, 2016-09-15 21:27:50]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-09-15 21:29:18]

Description was changed from

==========
A postmortem minidump dumper utility

BUG=620813
==========

to

==========
A postmortem minidump dumper utility

BUG=620813

Committed: https://crrev.com/0c23a7f9f36c34e897fe648e62702195e7334e40
Cr-Commit-Position: refs/heads/master@{#418980}
==========

[commit-bot: I haz the power, 2016-09-15 21:29:19]

Patchset 4 (id:??) landed as
https://crrev.com/0c23a7f9f36c34e897fe648e62702195e7334e40
Cr-Commit-Position: refs/heads/master@{#418980}