third_party/WebKit/Source/core/frame/VisualViewport.cpp - Issue 2339873002: Replace hide-scrollbars flag with a web setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.cpp

Issue 2339873002: Replace hide-scrollbars flag with a web setting. (Closed)

Patch Set: check for presence of settings using DCHECK + sync. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/VisualViewport.cpp

diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.cpp b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

index 9dfc058682ffdb2a627b0e1fc35b7aa1d901a1c1..7a17d8f862703db6a9e2535217e8fe1316937392 100644

--- a/third_party/WebKit/Source/core/frame/VisualViewport.cpp

+++ b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

@@ -425,7 +425,7 @@ void VisualViewport::initializeScrollbars()

if (!m_innerViewportContainerLayer)

return;

- if (visualViewportSuppliesScrollbars()) {

+ if (visualViewportSuppliesScrollbars() && !frameHost().settings().hideScrollbars()) {

if (!m_overlayScrollbarHorizontal->parent())

m_innerViewportContainerLayer->addChild(m_overlayScrollbarHorizontal.get());

if (!m_overlayScrollbarVertical->parent())