third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2339873002: Replace hide-scrollbars flag with a web setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2339873002: Replace hide-scrollbars flag with a web setting. (Closed)

Patch Set: check for presence of settings using DCHECK + sync. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 9c113fa546cb1428847a1678580544281c297372..73301f39f85cc0e332ddb5ce206b73238d389d79 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -3399,6 +3399,12 @@ void FrameView::setScrollbarModes(ScrollbarMode horizontalMode, ScrollbarMode ve

verticalMode = ScrollbarAlwaysOff;

}

+ DCHECK(m_frame->settings());

+ if (m_frame->settings()->hideScrollbars()) {

+ horizontalMode = ScrollbarAlwaysOff;

+ verticalMode = ScrollbarAlwaysOff;

+ }

if (horizontalMode != horizontalScrollbarMode() && !m_horizontalScrollbarLock) {

m_horizontalScrollbarMode = horizontalMode;

needsUpdate = true;