third_party/WebKit/LayoutTests/fast/scrolling/hide-scrollbars.html - Issue 2339873002: Replace hide-scrollbars flag with a web setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/scrolling/hide-scrollbars.html

Issue 2339873002: Replace hide-scrollbars flag with a web setting. (Closed)

Patch Set: check for presence of settings using DCHECK + sync. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/LayoutTests/fast/scrolling/hide-scrollbars.html

diff --git a/third_party/WebKit/LayoutTests/fast/scrolling/hide-scrollbars.html b/third_party/WebKit/LayoutTests/fast/scrolling/hide-scrollbars.html

index afdbac3a47832dafb0cd73a43e7c212f079443d2..e848af3aaee55083c18db981341cc4f26f85ad33 100644

--- a/third_party/WebKit/LayoutTests/fast/scrolling/hide-scrollbars.html

+++ b/third_party/WebKit/LayoutTests/fast/scrolling/hide-scrollbars.html

@@ -20,16 +20,13 @@ html, body {

if (window.internals) {

testRunner.dumpAsTextWithPixelResults();

- internals.settings.setOverlayScrollbarsEnabled(true);

- internals.settings.setMockScrollbarsEnabled(true);

- internals.runtimeFlags.hideScrollbarsEnabled = true;

+ internals.settings.setHideScrollbars(true);

}

</script>

</head>

<body>

<p>You should see 4 green boxes that do not show scrollbars.

-The first two boxes would show overlay scrollbars if they weren't

-hidden (second one with a scrollbar on the left).</p>

+They would show scrollbars if they weren't hidden (2nd and 4th with scrollbars on the left).</p>