Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: chromecast/browser/cast_content_browser_client.cc

Issue 2339873002: Replace hide-scrollbars flag with a web setting. (Closed)
Patch Set: replace viewport test b/c overlay bars are hidden in layout tests. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/browser/cast_content_browser_client.h" 5 #include "chromecast/browser/cast_content_browser_client.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 274 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 prefs->allow_scripts_to_close_windows = true; 285 prefs->allow_scripts_to_close_windows = true;
286 // TODO(lcwu): http://crbug.com/391089. This pref is set to true by default 286 // TODO(lcwu): http://crbug.com/391089. This pref is set to true by default
287 // because some content providers such as YouTube use plain http requests 287 // because some content providers such as YouTube use plain http requests
288 // to retrieve media data chunks while running in a https page. This pref 288 // to retrieve media data chunks while running in a https page. This pref
289 // should be disabled once all the content providers are no longer doing that. 289 // should be disabled once all the content providers are no longer doing that.
290 prefs->allow_running_insecure_content = true; 290 prefs->allow_running_insecure_content = true;
291 291
292 // Enable 5% margins for WebVTT cues to keep within title-safe area 292 // Enable 5% margins for WebVTT cues to keep within title-safe area
293 prefs->text_track_margin_percentage = 5; 293 prefs->text_track_margin_percentage = 5;
294 294
295 prefs->hide_scrollbars = true;
296
295 #if defined(OS_ANDROID) 297 #if defined(OS_ANDROID)
296 // Enable the television style for viewport so that all cast apps have a 298 // Enable the television style for viewport so that all cast apps have a
297 // 1280px wide layout viewport by default. 299 // 1280px wide layout viewport by default.
298 DCHECK(prefs->viewport_enabled); 300 DCHECK(prefs->viewport_enabled);
299 DCHECK(prefs->viewport_meta_enabled); 301 DCHECK(prefs->viewport_meta_enabled);
300 prefs->viewport_style = content::ViewportStyle::TELEVISION; 302 prefs->viewport_style = content::ViewportStyle::TELEVISION;
301 #endif // defined(OS_ANDROID) 303 #endif // defined(OS_ANDROID)
302 } 304 }
303 305
304 void CastContentBrowserClient::ResourceDispatcherHostCreated() { 306 void CastContentBrowserClient::ResourceDispatcherHostCreated() {
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
540 process_type, dumps_path, false /* upload */); 542 process_type, dumps_path, false /* upload */);
541 // StartUploaderThread() even though upload is diferred. 543 // StartUploaderThread() even though upload is diferred.
542 // Breakpad-related memory is freed in the uploader thread. 544 // Breakpad-related memory is freed in the uploader thread.
543 crash_handler->StartUploaderThread(); 545 crash_handler->StartUploaderThread();
544 return crash_handler; 546 return crash_handler;
545 } 547 }
546 #endif // !defined(OS_ANDROID) 548 #endif // !defined(OS_ANDROID)
547 549
548 } // namespace shell 550 } // namespace shell
549 } // namespace chromecast 551 } // namespace chromecast
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698