third_party/WebKit/Source/core/frame/Settings.in - Issue 2339873002: Replace hide-scrollbars flag with a web setting.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/frame/Settings.in

Issue 2339873002: Replace hide-scrollbars flag with a web setting. (Closed)

Patch Set: check for presence of settings using DCHECK + sync. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/frame/VisualViewport.cpp » ('j') | no next file with comments »

OLD	NEW
1 # Defines properties which are available on the Settings object.	1 # Defines properties which are available on the Settings object.

2 #	2 #

3 # Please think carefully before adding a new Setting. Some questions to	3 # Please think carefully before adding a new Setting. Some questions to

4 # consider are:	4 # consider are:

5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things	5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things

6 # which we support either values of at runtime. Features are set at renderer	6 # which we support either values of at runtime. Features are set at renderer

7 # process startup and are never changed. Features also tend to be set to a	7 # process startup and are never changed. Features also tend to be set to a

8 # value based on the platform or the stability of the code in question, where	8 # value based on the platform or the stability of the code in question, where

9 # as settings both codepaths need to be stable.	9 # as settings both codepaths need to be stable.

10 # - How will you ensure test coverage of all relevant values of your setting?	10 # - How will you ensure test coverage of all relevant values of your setting?

(...skipping 410 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
421 # Whether the CSSPreloadScanner is used for externally CSS preloads. NoPreload	421 # Whether the CSSPreloadScanner is used for externally CSS preloads. NoPreload

422 # indicates that the scanner will be used, but no preloads issued.	422 # indicates that the scanner will be used, but no preloads issued.

423 cssExternalScannerNoPreload initial=false	423 cssExternalScannerNoPreload initial=false

424 cssExternalScannerPreload initial=false	424 cssExternalScannerPreload initial=false

425	425

426 browserSideNavigationEnabled initial=false	426 browserSideNavigationEnabled initial=false

427	427

428 # Some platforms have media subsystems which are too buggy to allow preloading	428 # Some platforms have media subsystems which are too buggy to allow preloading

429 # of content by default. See http://crbug.com/612909 for details.	429 # of content by default. See http://crbug.com/612909 for details.

430 forcePreloadNoneForMediaElements initial=false	430 forcePreloadNoneForMediaElements initial=false

	431

	432 hideScrollbars initial=false

OLD	NEW