Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: chrome/browser/permissions/grouped_permission_infobar_delegate_android.h

Issue 2339863002: Use vector of PermissionRequest instead of ContentSettingsTypes for GroupedPermissionInfoBarDelegate (Closed)
Patch Set: fix patch failure Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PERMISSIONS_GROUPED_PERMISSION_INFOBAR_DELEGATE_ANDROID_H _ 5 #ifndef CHROME_BROWSER_PERMISSIONS_GROUPED_PERMISSION_INFOBAR_DELEGATE_ANDROID_H _
6 #define CHROME_BROWSER_PERMISSIONS_GROUPED_PERMISSION_INFOBAR_DELEGATE_ANDROID_H _ 6 #define CHROME_BROWSER_PERMISSIONS_GROUPED_PERMISSION_INFOBAR_DELEGATE_ANDROID_H _
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "components/content_settings/core/common/content_settings_types.h" 11 #include "components/content_settings/core/common/content_settings_types.h"
12 #include "components/infobars/core/confirm_infobar_delegate.h" 12 #include "components/infobars/core/confirm_infobar_delegate.h"
13 13
14 class GURL; 14 class GURL;
15 class InfoBarService; 15 class InfoBarService;
16 class PermissionRequest;
16 17
17 // An InfoBar that displays a group of permission requests, each of which can be 18 // An InfoBar that displays a group of permission requests, each of which can be
18 // allowed or blocked independently. 19 // allowed or blocked independently.
19 // TODO(tsergeant): Expand this class so it can be used without subclassing. 20 // TODO(tsergeant): Expand this class so it can be used without subclassing.
20 class GroupedPermissionInfoBarDelegate : public ConfirmInfoBarDelegate { 21 class GroupedPermissionInfoBarDelegate : public ConfirmInfoBarDelegate {
21 public: 22 public:
22 // Public so we can have std::unique_ptr<GroupedPermissionInfoBarDelegate>. 23 // Public so we can have std::unique_ptr<GroupedPermissionInfoBarDelegate>.
23 ~GroupedPermissionInfoBarDelegate() override; 24 ~GroupedPermissionInfoBarDelegate() override;
24 25
25 static infobars::InfoBar* Create( 26 static infobars::InfoBar* Create(
26 InfoBarService* infobar_service, 27 InfoBarService* infobar_service,
27 const GURL& requesting_origin, 28 const GURL& requesting_origin,
28 const std::vector<ContentSettingsType>& types); 29 const std::vector<PermissionRequest*>& requests);
29 30
30 bool persist() const { return persist_; } 31 bool persist() const { return persist_; }
31 void set_persist(bool persist) { persist_ = persist; } 32 void set_persist(bool persist) { persist_ = persist; }
32 size_t permission_count() const { return types_.size(); } 33 size_t permission_count() const { return requests_.size(); }
33 34
34 // Returns true if the infobar should display a toggle to allow users to 35 // Returns true if the infobar should display a toggle to allow users to
35 // opt-out of persisting their accept/deny decision. 36 // opt-out of persisting their accept/deny decision.
36 bool ShouldShowPersistenceToggle() const; 37 bool ShouldShowPersistenceToggle() const;
37 38
38 ContentSettingsType GetContentSettingType(size_t position) const; 39 ContentSettingsType GetContentSettingType(size_t position) const;
39 int GetIconIdForPermission(size_t position) const; 40 int GetIconIdForPermission(size_t position) const;
40 41
41 // Message text to display for an individual permission at |position|. 42 // Message text to display for an individual permission at |position|.
42 base::string16 GetMessageTextFragment(size_t position) const; 43 base::string16 GetMessageTextFragment(size_t position) const;
43 44
44 // Toggle accept value for an individual permission at |position|. 45 // Toggle accept value for an individual permission at |position|.
45 void ToggleAccept(size_t position, bool new_value); 46 void ToggleAccept(size_t position, bool new_value);
46 47
47 // ConfirmInfoBarDelegate: 48 // ConfirmInfoBarDelegate:
48 base::string16 GetMessageText() const override; 49 base::string16 GetMessageText() const override;
49 50
50 protected: 51 protected:
51 bool GetAcceptState(size_t position); 52 bool GetAcceptState(size_t position);
52 53
53 private: 54 private:
54 GroupedPermissionInfoBarDelegate( 55 GroupedPermissionInfoBarDelegate(
55 const GURL& requesting_origin, 56 const GURL& requesting_origin,
56 const std::vector<ContentSettingsType>& types); 57 const std::vector<PermissionRequest*>& requests);
57 58
58 // ConfirmInfoBarDelegate: 59 // ConfirmInfoBarDelegate:
59 InfoBarIdentifier GetIdentifier() const override; 60 InfoBarIdentifier GetIdentifier() const override;
60 Type GetInfoBarType() const override; 61 Type GetInfoBarType() const override;
61 int GetButtons() const override; 62 int GetButtons() const override;
62 base::string16 GetButtonLabel(InfoBarButton button) const override; 63 base::string16 GetButtonLabel(InfoBarButton button) const override;
63 64
64 const GURL requesting_origin_; 65 const GURL requesting_origin_;
65 const std::vector<ContentSettingsType> types_; 66 const std::vector<PermissionRequest*> requests_;
66 std::vector<bool> accept_states_; 67 std::vector<bool> accept_states_;
67 // Whether the accept/deny decision is persisted. 68 // Whether the accept/deny decision is persisted.
68 bool persist_; 69 bool persist_;
69 70
70 DISALLOW_COPY_AND_ASSIGN(GroupedPermissionInfoBarDelegate); 71 DISALLOW_COPY_AND_ASSIGN(GroupedPermissionInfoBarDelegate);
71 }; 72 };
72 73
73 #endif // CHROME_BROWSER_PERMISSIONS_GROUPED_PERMISSION_INFOBAR_DELEGATE_ANDROI D_H_ 74 #endif // CHROME_BROWSER_PERMISSIONS_GROUPED_PERMISSION_INFOBAR_DELEGATE_ANDROI D_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698