Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2339853004: Avoid merging conditions across loop boundary (Closed)

Created:
4 years, 3 months ago by sra1
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 1 chunk +2 lines, -1 line 0 comments Download
A tests/compiler/dart2js_extra/27354_test.dart View 1 1 chunk +14 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (4 generated)
sra1
4 years, 3 months ago (2016-09-14 23:59:27 UTC) #3
Siggi Cherem (dart-lang)
lgtm, thanks Stephen! https://codereview.chromium.org/2339853004/diff/40001/tests/compiler/dart2js_extra/27354_test.dart File tests/compiler/dart2js_extra/27354_test.dart (right): https://codereview.chromium.org/2339853004/diff/40001/tests/compiler/dart2js_extra/27354_test.dart#newcode8 tests/compiler/dart2js_extra/27354_test.dart:8: void inc() => total++ < 10 ...
4 years, 3 months ago (2016-09-15 00:07:10 UTC) #5
sra1
4 years, 3 months ago (2016-09-15 00:08:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
591f8ea79e6145cae6a61e1db6a1ff229fd344c9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698