Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5019)

Unified Diff: chrome/browser/resources/settings/reset_page/reset_page.js

Issue 2339853003: MD Settings: Fix Reset profile dialog scenario that causes a crash. (Closed)
Patch Set: Nit Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/reset_page/reset_page.js
diff --git a/chrome/browser/resources/settings/reset_page/reset_page.js b/chrome/browser/resources/settings/reset_page/reset_page.js
index 6e6e3900b2043defc70b98f0f18f5bb7ee1da2d6..6fa17744a7aa4a3c1a01bbdd276d7cc21c2e063e 100644
--- a/chrome/browser/resources/settings/reset_page/reset_page.js
+++ b/chrome/browser/resources/settings/reset_page/reset_page.js
@@ -19,6 +19,12 @@ Polymer({
is: 'settings-reset-page',
properties: {
+<if expr="chromeos">
+ /** @private */
+ showPowerwashDialog_: Boolean,
+</if>
+
+ /** @private */
allowPowerwash_: {
type: Boolean,
value: cr.isChromeOS ? loadTimeData.getBoolean('allowPowerwash') : false
@@ -27,27 +33,18 @@ Polymer({
/** @private */
onShowResetProfileDialog_: function() {
- this.showDialog_('settings-reset-profile-dialog');
+ this.$.resetProfileDialog.get().open();
},
+<if expr="chromeos">
/** @private */
onShowPowerwashDialog_: function() {
- this.showDialog_('settings-powerwash-dialog');
+ this.showPowerwashDialog_ = true;
},
-
- /**
- * Creates and shows the specified dialog.
- * @param {string} dialogName
- * @private
- */
- showDialog_: function(dialogName) {
- var dialog = document.createElement(dialogName);
- this.shadowRoot.appendChild(dialog);
- dialog.open();
-
- dialog.addEventListener('close', function() {
- dialog.remove();
- });
+ /** @private */
+ onPowerwashDialogClose_: function() {
+ this.showPowerwashDialog_ = false;
},
+</if>
});

Powered by Google App Engine
This is Rietveld 408576698