MD Settings: Fix Reset profile dialog scenario that causes a crash.

chrome/browser/resources/settings/reset_page/reset_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-reset-page' is the settings page containing reset
  * settings.
  *
  * Example:
  *
  *    <iron-animated-pages>
  *      <settings-reset-page prefs="{{prefs}}">
  *      </settings-reset-page>
  *      ... other pages ...
  *    </iron-animated-pages>
  */
 Polymer({
   is: 'settings-reset-page',
 
   properties: {
+    showResetProfileDialog_: Boolean,
+
     allowPowerwash_: {
       type: Boolean,
       value: cr.isChromeOS ? loadTimeData.getBoolean('allowPowerwash') : false
     },
   },
 
   /** @private */
   onShowResetProfileDialog_: function() {
-    this.showDialog_('settings-reset-profile-dialog');
+    this.showResetProfileDialog_ = true;
+    this.async(function() {
+      this.$$('settings-reset-profile-dialog').open();

[Dan Beam, 2016/09/15 21:15:40]

wait, why is this better than the original code?

+    }.bind(this));
   },
 
   /** @private */
   onShowPowerwashDialog_: function() {
     this.showDialog_('settings-powerwash-dialog');

[Dan Beam, 2016/09/15 21:15:40]

this is only used once now

[dpapad, 2016/09/20 00:52:36]

Removed. Using the DOM to construct the dialog, instead of doing it
programmatically.

   },
 
 

[Dan Beam, 2016/09/15 21:15:40]

\n\n -> \n

[dpapad, 2016/09/20 00:52:36]

Removed.

   /**
    * Creates and shows the specified dialog.
    * @param {string} dialogName
    * @private
    */
   showDialog_: function(dialogName) {
     var dialog = document.createElement(dialogName);
     this.shadowRoot.appendChild(dialog);
     dialog.open();
 
     dialog.addEventListener('close', function() {
       dialog.remove();
     });
   },
 });