Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2339853002: Convert editing/inserting/insert-at-end-0[12].html to use w3c test harness (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/inserting/insert-at-end-0[12].html to use w3c test harness This patch converts "editing/inserting/insert-at-end-0[12].html" to use w3c test harness to simplify test script, and consolidates into "insert_at_end.html" since these scripts use similar sample, for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/6e49adc69ffc520e32ee9ee9fe2be2d24fd2107c Cr-Commit-Position: refs/heads/master@{#418820}

Patch Set 1 : 2016-09-14T15:19:59 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -265 lines) Patch
D third_party/WebKit/LayoutTests/editing/inserting/insert-at-end-01.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/inserting/insert-at-end-02.html View 1 chunk +0 lines, -34 lines 0 comments Download
A + third_party/WebKit/LayoutTests/editing/inserting/insert_at_end.html View 1 chunk +11 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-at-end-01-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-at-end-01-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-at-end-02-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-at-end-02-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-at-end-01-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-at-end-01-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-at-end-02-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-at-end-02-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-at-end-01-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-at-end-01-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-at-end-02-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-at-end-02-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-09-14 07:12:14 UTC) #5
Xiaocheng
The original test verifies canonicalization by try to over-move the caret to (<br>, 1). I ...
4 years, 3 months ago (2016-09-14 10:11:17 UTC) #8
yosin_UTC9
On 2016/09/14 at 10:11:17, xiaochengh wrote: > The original test verifies canonicalization by try to ...
4 years, 3 months ago (2016-09-15 05:30:42 UTC) #9
Xiaocheng
On 2016/09/15 at 05:30:42, yosin wrote: > On 2016/09/14 at 10:11:17, xiaochengh wrote: > > ...
4 years, 3 months ago (2016-09-15 08:57:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339853002/1
4 years, 3 months ago (2016-09-15 09:02:33 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 10:04:46 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 10:07:39 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e49adc69ffc520e32ee9ee9fe2be2d24fd2107c
Cr-Commit-Position: refs/heads/master@{#418820}

Powered by Google App Engine
This is Rietveld 408576698